[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 6640188: Methods com.sun.tools.attach.VirtualMachine.load... don't throw NullPointerExcepti
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2018-01-04 20:13:53
Message-ID: 7836ad63-abae-15d0-f5c7-d9f1fc74f624 () oracle ! com
[Download RAW message or body]

Hi Gary,

The fix looks good.
I agree, the other null checks are already covered in the 
VirtualMachine.java.


Thanks,
Serguei


On 1/4/18 07:54, gary.adams@oracle.com wrote:
> Here's a simple fix to add explicit checks for the loadAgentXXX 
> methods to
> ensure NPE is thrown when null arguments are passed. Several other 
> management
> methods have similar provider not null checks, they just were not 
> present for
> agent path and library methods. This should remove the spec ambiguity 
> with
> AgentLoadException which was being thrown.
>
>    Issue: https://bugs.openjdk.java.net/browse/JDK-6640188
>    Webrev: http://cr.openjdk.java.net/~gadams/6640188/

[prev in list] [next in list] [prev in thread] [next in thread]