'Re: DOC RFR: 8187448: 360 doc issues in jdwp-protocol.html'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: DOC RFR: 8187448: 360 doc issues in jdwp-protocol.html
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2017-12-22 19:49:52
Message-ID: 786a91cb-e8c6-3450-996d-c6dbc89e1659 () oracle ! com
[Download RAW message or body]

Hi Daniil,

The fix looks good to me.
Thank you for taking care about this!

Thanks,
Serguei


On 12/22/17 09:39, Daniil Titov wrote:
> Please review a fix for the doc bug.
> 
> The fix does the following:
> 1. Removes empty <ul> elements.
> 2. Adds an outer <ul> element to the index section .
> 3. Removes obsolete in HTML5 "summary" attribute in <table> elements.
> 4. Removes empty <p> elements.
> 5. Replaces not supported in HTML5 "bgcolor" attribute for <body> element with \
> "style="background-color"" attribute. 6. Removes <dd> element in  ConstantSetNode  \
> (there is no outer <dl> element in this case) 7. Adds required by accessibility \
> audits "lang" attribute for <html> element. 
> Testing:
> 1. Built the docs target and looked at the resulting jdwp-protocol.html.
> 2. Tested that is passes validation with tidy
> 3. Tested it passes accessibility audits with Accessibility Developer Tool (Chrome)
> 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8187448
> Webrev: http://cr.openjdk.java.net/~dtitov/8187448/webrev.01
> 
> Thanks,
> Daniil
> 
> 
> 
> 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic