[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: JDK-8180709: java -javaagent:agent.jar with run-time that does not contain java.instrument
From: "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date: 2017-12-20 18:21:14
Message-ID: 9085b115-cb7d-ff32-ef43-a0d928f7224b () oracle ! com
[Download RAW message or body]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Gary,<br>
<br>
<br>
On 12/20/17 05:28, Gary Adams wrote:<br>
</div>
<blockquote type="cite" cite="mid:5A3A657C.2050809@oracle.com">Is
the patch file in the webrev sufficient?
<br>
<br>
<a class="moz-txt-link-freetext" \
href="http://bussund0416.us.oracle.com/export/users/gradams/work/webrevs/8180709/webre \
v.01/jdk-hs.patch">http://bussund0416.us.oracle.com/export/users/gradams/work/webrevs/8180709/webrev.01/jdk-hs.patch</a><br>
<br>
For testing I had been running the closed tonga all.testlist and
the open jdk-tier1 tests.<br>
</blockquote>
<br>
Not sure, what coverage for j.l.instrument API is in the tonga
tests.<br>
It seems, the only vm.defmeth has it.<br>
The :jdk_instrument (open/test/jdk/java/lang/instrument) test suite
is what is normally needed.<br>
In this particular case any coverage might be enough though. :)<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
<blockquote type="cite" cite="mid:5A3A657C.2050809@oracle.com">
<br>
But to demonstrate the error message, I would locally build "make
profiles"
<br>
and then compare jre-compact2 and jre-compact3 results. The
compact2
<br>
profile does not include java.instrument, but compact3 does.<br>
</blockquote>
<br>
Good idea.<br>
I don't know how to run the mach5 for compact profiles.<br>
Most likely, your plan is to build and run tests locally.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
<blockquote type="cite" cite="mid:5A3A657C.2050809@oracle.com">
<br>
On 12/19/17, 5:50 PM, Chris Plummer wrote:
<br>
<blockquote type="cite">I can push it this evening if no one else
grabs it first (need to step out for a bit and won't be able to
monitor CI results). Please produce a changeset first.
<br>
<br>
thanks,
<br>
<br>
Chris
<br>
<br>
On 12/19/17 2:47 PM, <a class="moz-txt-link-abbreviated" \
href="mailto:gary.adams@oracle.com">gary.adams@oracle.com</a> wrote: <br>
<blockquote type="cite">Now comes the catch ...
<br>
I'll need a sponsor. </blockquote>
</blockquote>
<br>
</blockquote>
<font face="Monaco"> </font><br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic