[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR : JDK-8175542 - JMX: Not enough JDP packets received
From: Harsha Wardhana B <harsha.wardhana.b () oracle ! com>
Date: 2017-12-13 12:14:11
Message-ID: 2b05b6b7-e731-7bf0-83b9-cdb2a4252d84 () oracle ! com
[Download RAW message or body]
Hi Amit,
Increasing the timeout 'TIME_OUT_FACTOR' will increase both socket and
test-case timeout. The test passed as can be seen from the log, but
because of the race-condition: hasTestLivedLongEnough() checked before
shouldContinue(), the test was declared failed because of time-out.
One possible fix would be to change line 80 to,
if (shouldContinue() && hasTestLivedLongEnough())
Thanks
Harsha
On Wednesday 13 December 2017 11:03 AM, Amit Sapre wrote:
>
> Hello,
>
> Please review the timeout fix for this bug.
>
> Bug ID : https://bugs.openjdk.java.net/browse/JDK-8175542
>
> Webrev :
> http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8175542/webrev.00/
> <http://cr.openjdk.java.net/%7Easapre/webrev/2017/JDK-8175542/webrev.00/>
>
> Thanks,
>
> Amit
>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Amit,</p>
<p>Increasing the timeout 'TIME_OUT_FACTOR' will increase both
socket and test-case timeout. The test passed as can be seen from
the log, but because of the race-condition:
hasTestLivedLongEnough() checked before shouldContinue(), the test
was declared failed because of time-out.</p>
<p>One possible fix would be to change line 80 to,</p>
<p> if (shouldContinue() &&
hasTestLivedLongEnough())</p>
<p>Thanks</p>
<p>Harsha<br>
</p>
<br>
<div class="moz-cite-prefix">On Wednesday 13 December 2017 11:03 AM,
Amit Sapre wrote:<br>
</div>
<blockquote type="cite"
cite="mid:d2f224f8-4941-4dbe-b4c5-38452ea797b3@default">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hello,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the timeout fix for this \
bug.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Bug ID : <a
href="https://bugs.openjdk.java.net/browse/JDK-8175542"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8175542</a>
<o:p></o:p></p>
<p class="MsoNormal">Webrev : <a
href="http://cr.openjdk.java.net/%7Easapre/webrev/2017/JDK-8175542/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8175542/webrev.00/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Amit<o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic