[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RE: RFR (S): 8193258: Better usage of JDWP HEADER SIZE
From: "Langer, Christoph" <christoph.langer () sap ! com>
Date: 2017-12-12 8:50:26
Message-ID: 6c54ec8a39ea48f6a76b49b4d1855f85 () sap ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
Hi,
no problem. I already thought that I would not be able to see this.
I pushed it: http://hg.openjdk.java.net/jdk/jdk/rev/61e60548c0cf
Thanks for all your help in reviewing/testing this.
Best regards
Christoph
From: serguei.spitsyn@oracle.com [mailto:serguei.spitsyn@oracle.com]
Sent: Dienstag, 12. Dezember 2017 07:35
To: Chris Plummer <chris.plummer@oracle.com>; Langer, Christoph \
<christoph.langer@sap.com>; serviceability-dev@openjdk.java.net
Subject: Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE
Yes.
That was stupid. :(
Thanks, Chris!
Serguei
On 12/11/17 22:24, Chris Plummer wrote:
That's an internal link. Christoph won't be able to see them.
Chris
On 12/11/17 9:50 PM, serguei.spitsyn@oracle.com<mailto:serguei.spitsyn@oracle.com> \
wrote: Hi Christoph,
The testing looks good.
These are the results:
http://java.se.oracle.com:10065/mdash/jobs/sspitsyn-clanger-JDK-8193258-20171212-0054-7258
The job includes hs-tier's from 1-5.
There are some failures there but nothing related to the JDI or JDWP tests.
Thanks,
Serguei
On 12/11/17 11:10, serguei.spitsyn@oracle.com<mailto:serguei.spitsyn@oracle.com> \
wrote: Hi Christoph,
The fix looks good to me.
I'll submit a mach5 job to make sure nothing is broken.
Thanks,
Serguei
On 12/11/17 07:43, Langer, Christoph wrote:
Hi Serguei, Chris,
please look at this webrev: \
http://cr.openjdk.java.net/~clanger/webrevs/8193258.2/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8193258.2/>
I spotted a few other locations in libdt_shmem where JDWP HEADER SIZE should be used. \
Builds and tests running…
Best regards
Christoph
From: Langer, Christoph
Sent: Sonntag, 10. Dezember 2017 10:52
To: 'serguei.spitsyn@oracle.com<mailto:serguei.spitsyn@oracle.com>' \
<serguei.spitsyn@oracle.com><mailto:serguei.spitsyn@oracle.com>; \
serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net>
Cc: Chris Plummer <chris.plummer@oracle.com><mailto:chris.plummer@oracle.com>
Subject: RE: RFR (S): 8193258: Better usage of JDWP HEADER SIZE
Hi Serguei,
I wasn't aware that the jdk/com/sun/jdi tests would test libjdwp, I just found \
hotspot/jtreg/serviceability/jdwp when searching for jdwp in the tests. But thanks to \
your hints I know better now. In fact I ran the jdi tests when testing my change for \
8193183.
I made a new webrev which includes the removal of inStream_endOfInput: \
http://cr.openjdk.java.net/~clanger/webrevs/8193258.1/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8193258.1/>. \
Can you please approve this.
This time I ran the jdi tests without issues and also did builds on Windows, linux \
x86, AIX, Solaris and Mac. J
Best regards
Christoph
From: serguei.spitsyn@oracle.com<mailto:serguei.spitsyn@oracle.com> \
[mailto:serguei.spitsyn@oracle.com]
Sent: Samstag, 9. Dezember 2017 06:27
To: Langer, Christoph <christoph.langer@sap.com<mailto:christoph.langer@sap.com>>; \
serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net>; \
Chris Plummer \
<chris.plummer@oracle.com<mailto:chris.plummer@oracle.com>>
Subject: Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE
Hi Christoph,
You need to run at least the jdk/com/sun/jdi tests.
Thanks,
Serguei
On 12/8/17 13:07, Langer, Christoph wrote:
Hi Serguei,
I did only run hotspot/jtreg/serviceability/jdwp, didn't find a lot more in that \
area. I'm hoping/waiting for Chris' tests then.
I agree, I will then remove inStream_endOfInput. If something like that is needed for \
future developments, it can easily be added again.
Best regards
Christoph
From: serguei.spitsyn@oracle.com<mailto:serguei.spitsyn@oracle.com> \
[mailto:serguei.spitsyn@oracle.com]
Sent: Freitag, 8. Dezember 2017 21:12
To: Langer, Christoph <christoph.langer@sap.com><mailto:christoph.langer@sap.com>; \
serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net>; \
Chris Plummer \
<chris.plummer@oracle.com><mailto:chris.plummer@oracle.com>
Subject: Re: RFR (S): 8193258: Better usage of JDWP HEADER SIZE
Hi Christoph,
The fix looks good to me.
What tests did you run?
On 12/8/17 07:07, Langer, Christoph wrote:
Hi,
Here's a proposal to clean up the usage of the JDWP header size within the source \
code of libjdwp.
Bug: https://bugs.openjdk.java.net/browse/JDK-8193258
WebRev: http://cr.openjdk.java.net/~clanger/webrevs/8193258.0/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8193258.0/>
As for inStream.c, I'm wondering wether inStream_endOfInput shall be removed? It \
seems to be unused…
I'm inclined to remove it.
Otherwise, it must be:
417 return (stream->left <= 0);
Thanks,
Serguei
Best regards
Christoph
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.changed
{mso-style-name:changed;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US">no \
problem. I already thought that I would not be able to see \
this.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US">I \
pushed it: <a href="http://hg.openjdk.java.net/jdk/jdk/rev/61e60548c0cf">http://hg.openjdk.java.net/jdk/jdk/rev/61e60548c0cf</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US">Thanks \
for all your help in reviewing/testing this.<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US">Best \
regards<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US">Christoph<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span lang="EN-US" \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></a></p> <span \
style="mso-bookmark:_MailEndCompose"></span> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-left:35.4pt"><b><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span \
lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"> \
serguei.spitsyn@oracle.com [mailto:serguei.spitsyn@oracle.com] <br>
<b>Sent:</b> Dienstag, 12. Dezember 2017 07:35<br>
<b>To:</b> Chris Plummer <chris.plummer@oracle.com>; Langer, Christoph \
<christoph.langer@sap.com>; serviceability-dev@openjdk.java.net<br> \
<b>Subject:</b> Re: RFR (S): 8193258: Better usage of JDWP HEADER \
SIZE<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal" style="margin-left:35.4pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">Yes.<br>
That was stupid. :(<br>
<br>
Thanks, Chris!<br>
Serguei<br>
<br>
<br>
On 12/11/17 22:24, Chris Plummer wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" style="margin-left:35.4pt">That's an internal link. Christoph \
won't be able to see them.<br> <br>
Chris<br>
<br>
On 12/11/17 9:50 PM, <a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> \
wrote:<o:p></o:p></p> </div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" style="margin-left:35.4pt">Hi Christoph,<br>
<br>
The testing looks good.<br>
These are the results:<br>
<a href="http://java.se.oracle.com:10065/mdash/jobs/sspitsyn-clanger-JDK-8193258-20171212-0054-7258">
http://java.se.oracle.com:10065/mdash/jobs/sspitsyn-clanger-JDK-8193258-20171212-0054-7258</a><br>
<br>
The job includes hs-tier's from 1-5.<br>
There are some failures there but nothing related to the JDI or JDWP tests.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 12/11/17 11:10, <a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> \
wrote:<o:p></o:p></p> </div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" style="margin-left:35.4pt">Hi Christoph,<br>
<br>
The fix looks good to me.<br>
I'll submit a mach5 job to make sure nothing is broken.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
<br>
On 12/11/17 07:43, Langer, Christoph wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> Hi \
Serguei, Chris,<o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">please look at this webrev: <a \
href="http://cr.openjdk.java.net/%7Eclanger/webrevs/8193258.2/"> \
http://cr.openjdk.java.net/~clanger/webrevs/8193258.2/</a></span><o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt">
<span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">I spotted a few other locations in libdt_shmem where JDWP HEADER SIZE \
should be used. Builds and tests running…</span><o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt">
<span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">Best regards</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">Christoph</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US"> </span><o:p></o:p></p> <div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<b><span lang="EN-US">From:</span></b><span lang="EN-US"> Langer, Christoph <br> \
<b>Sent:</b> Sonntag, 10. Dezember 2017 10:52<br> <b>To:</b> '<a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>' <a \
href="mailto:serguei.spitsyn@oracle.com"><serguei.spitsyn@oracle.com></a>; <a \
href="mailto:serviceability-dev@openjdk.java.net"> \
serviceability-dev@openjdk.java.net</a><br> <b>Cc:</b> Chris Plummer <a \
href="mailto:chris.plummer@oracle.com"><chris.plummer@oracle.com></a><br> \
<b>Subject:</b> RE: RFR (S): 8193258: Better usage of JDWP HEADER \
SIZE</span><o:p></o:p></p> </div>
</div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> Hi \
Serguei,<o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">I wasn't aware that the jdk/com/sun/jdi tests would test libjdwp, I just \
found hotspot/jtreg/serviceability/jdwp when searching for jdwp in the tests. But \
thanks to your hints I know better now. In fact I ran the jdi tests when testing my \
change for 8193183.</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">I made a new webrev which includes the removal of inStream_endOfInput: \
<a href="http://cr.openjdk.java.net/%7Eclanger/webrevs/8193258.1/">http://cr.openjdk.java.net/~clanger/webrevs/8193258.1/</a>. \
Can you please approve this.</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">This time I ran the jdi tests without issues and also did builds on \
Windows, linux x86, AIX, Solaris and Mac. J</span><o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt">
<span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">Best regards</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">Christoph</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US"> </span><o:p></o:p></p> <div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<b><span lang="EN-US">From:</span></b><span lang="EN-US"> <a \
href="mailto:serguei.spitsyn@oracle.com"> serguei.spitsyn@oracle.com</a> [<a \
href="mailto:serguei.spitsyn@oracle.com">mailto:serguei.spitsyn@oracle.com</a>] <br>
<b>Sent:</b> Samstag, 9. Dezember 2017 06:27<br>
<b>To:</b> Langer, Christoph <<a \
href="mailto:christoph.langer@sap.com">christoph.langer@sap.com</a>>; <a \
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a>; \
Chris Plummer <<a \
href="mailto:chris.plummer@oracle.com">chris.plummer@oracle.com</a>><br> \
<b>Subject:</b> Re: RFR (S): 8193258: Better usage of JDWP HEADER \
SIZE</span><o:p></o:p></p> </div>
</div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<o:p></o:p></p> <div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> Hi \
Christoph,<br> <br>
You need to run at least the jdk/com/sun/jdi tests.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 12/8/17 13:07, Langer, Christoph wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> Hi \
Serguei,<o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">I did only run hotspot/jtreg/serviceability/jdwp, didn't find a lot more \
in that area. I'm hoping/waiting for Chris' tests then.</span><o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt">
<span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">I agree, I will then remove inStream_endOfInput. If something like that \
is needed for future developments, it can easily be added \
again.</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">Best regards</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">Christoph</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US"> </span><o:p></o:p></p> <div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<b><span lang="EN-US">From:</span></b><span lang="EN-US"> <a \
href="mailto:serguei.spitsyn@oracle.com"> serguei.spitsyn@oracle.com</a> [<a \
href="mailto:serguei.spitsyn@oracle.com">mailto:serguei.spitsyn@oracle.com</a>] <br>
<b>Sent:</b> Freitag, 8. Dezember 2017 21:12<br>
<b>To:</b> Langer, Christoph <a \
href="mailto:christoph.langer@sap.com"><christoph.langer@sap.com></a>; <a \
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a>; \
Chris Plummer <a href="mailto:chris.plummer@oracle.com"><chris.plummer@oracle.com></a><br>
<b>Subject:</b> Re: RFR (S): 8193258: Better usage of JDWP HEADER \
SIZE</span><o:p></o:p></p> </div>
</div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<o:p></o:p></p> <div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> Hi \
Christoph,<br> <br>
The fix looks good to me.<br>
What tests did you run?<br>
<br>
<br>
On 12/8/17 07:07, Langer, Christoph wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
Hi,<o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">Here's a proposal to clean up the usage of the JDWP header size within \
the source code of libjdwp.</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8193258"> \
https://bugs.openjdk.java.net/browse/JDK-8193258</a></span><o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt">
<span lang="EN-US">WebRev: <a \
href="http://cr.openjdk.java.net/%7Eclanger/webrevs/8193258.0/"> \
http://cr.openjdk.java.net/~clanger/webrevs/8193258.0/</a></span><o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt">
<span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">As for inStream.c, I'm wondering wether inStream_endOfInput shall be \
removed? It seems to be unused…</span><o:p></o:p></p> </div>
</blockquote>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <br>
I'm inclined to remove it.<br>
Otherwise, it must be:<br>
<span class="changed"> 417 return (stream->left <= 0);</span><br>
<span lang="EN-US"><br>
Thanks,<br>
Serguei<br>
</span><o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">Best regards</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US">Christoph</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> <span \
lang="EN-US"> </span><o:p></o:p></p> </div>
</blockquote>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<o:p></o:p></p> </div>
</blockquote>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:35.4pt"> \
<o:p></o:p></p> </div>
</blockquote>
<p class="MsoNormal" style="margin-left:35.4pt"><o:p> </o:p></p>
</blockquote>
<p class="MsoNormal" style="margin-left:35.4pt"><o:p> </o:p></p>
</blockquote>
<p style="margin-left:35.4pt"><o:p> </o:p></p>
</blockquote>
<p class="MsoNormal" style="margin-left:35.4pt"><o:p> </o:p></p>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic