[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RE: RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c
From: "Langer, Christoph" <christoph.langer () sap ! com>
Date: 2017-12-08 8:57:40
Message-ID: cbdf95536f524b9390f975bf3d19be27 () sap ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
Done: http://hg.openjdk.java.net/jdk/jdk/rev/8ad12da0cbc7
Thanks
Christoph
From: Chris Plummer [mailto:chris.plummer@oracle.com]
Sent: Freitag, 8. Dezember 2017 06:48
To: Langer, Christoph <christoph.langer@sap.com>; \
serviceability-dev@openjdk.java.net; serguei.spitsyn@oracle.com
Cc: Lindenmaier, Goetz <goetz.lindenmaier@sap.com>
Subject: Re: RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c
Hi Christoph,
Testing is done. All clear to push. I'll let you have the honors. :)
Chris
On 12/7/17 1:28 PM, Langer, Christoph wrote:
Hi Chris,
ok, I understand. Then please let me know when you're done or …in that case you \
might as well do the push.:)
Thanks
Christoph
From: Chris Plummer [mailto:chris.plummer@oracle.com]
Sent: Donnerstag, 7. Dezember 2017 20:26
To: Langer, Christoph <christoph.langer@sap.com><mailto:christoph.langer@sap.com>; \
serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net>; \
serguei.spitsyn@oracle.com<mailto:serguei.spitsyn@oracle.com>
Cc: Lindenmaier, Goetz <goetz.lindenmaier@sap.com><mailto:goetz.lindenmaier@sap.com>
Subject: Re: RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c
Hi Christoph,
You can do the push, but please let me do some internal testing first. I want to make \
sure all our platforms are covered, and our closed tests are turn.
thanks,
Chris
On 12/7/17 11:02 AM, Langer, Christoph wrote:
Thanks Chris and Serguei for reviewing.
I can do the push myself as it isn't hotspot. I'll send out other webrevs tomorrow \
for the other stuff.
Best regards
Christoph
From: Chris Plummer [mailto:chris.plummer@oracle.com]
Sent: Donnerstag, 7. Dezember 2017 19:14
To: Langer, Christoph <christoph.langer@sap.com><mailto:christoph.langer@sap.com>; \
serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net>
Cc: Lindenmaier, Goetz <goetz.lindenmaier@sap.com><mailto:goetz.lindenmaier@sap.com>
Subject: Re: RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c
Looks good to me. I can sponsor the push for you.
thanks,
Chris
On 12/7/17 7:21 AM, Langer, Christoph wrote:
Hi,
please review the first extracted patch from 8192978. This one is about correcting \
the jlong format string in src/jdk.jdi/share/native/libdt_shmem/shmemBase.c.
Bug: https://bugs.openjdk.java.net/browse/JDK-8193183
WebRev: http://cr.openjdk.java.net/~clanger/webrevs/8193183.0/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8193183.0/>
I believe the libdt_shmem is only built on windows.
Thanks,
Christoph
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Done:</span><span \
lang="EN-US" style="font-size:10.5pt;font-family:"Arial",sans-serif;position:relative;top:-1.5pt;mso-text-raise:1.5pt">
</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;position:relative;top:-1.5pt;mso-text-raise:1.5pt"><a \
href="http://hg.openjdk.java.net/jdk/jdk/rev/8ad12da0cbc7"><span lang="EN-US" \
style="color:#3B73AF;text-decoration:none">http://hg.openjdk.java.net/jdk/jdk/rev/8ad12da0cbc7</span></a></span><span \
lang="EN-US" style="font-size:10.5pt;font-family:"Arial",sans-serif;position:relative;top:-1.5pt;mso-text-raise:1.5pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" \
style="font-size:10.5pt;font-family:"Arial",sans-serif;position:relative;top:-1.5pt;mso-text-raise:1.5pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span \
style="font-size:10.5pt;font-family:"Arial",sans-serif;position:relative;top:-1.5pt;mso-text-raise:1.5pt">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span \
style="font-size:10.5pt;font-family:"Arial",sans-serif;position:relative;top:-1.5pt;mso-text-raise:1.5pt">Christoph</span><span \
lang="EN-US" style="color:windowtext"><o:p></o:p></span></p> <p class="MsoNormal"><a \
name="_MailEndCompose"><span lang="EN-US"><o:p> </o:p></span></a></p> <span \
style="mso-bookmark:_MailEndCompose"></span> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-left:35.4pt"><b><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:DE"> Chris Plummer \
[mailto:chris.plummer@oracle.com] <br>
<b>Sent:</b> Freitag, 8. Dezember 2017 06:48<br>
<b>To:</b> Langer, Christoph <christoph.langer@sap.com>; \
serviceability-dev@openjdk.java.net; serguei.spitsyn@oracle.com<br> <b>Cc:</b> \
Lindenmaier, Goetz <goetz.lindenmaier@sap.com><br> <b>Subject:</b> Re: RFR \
(XS): 8193183: Fix format string in libdt_shmem/shmemBase.c<o:p></o:p></span></p> \
</div> </div>
<p class="MsoNormal" style="margin-left:35.4pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">Hi Christoph,<br>
<br>
Testing is done. All clear to push. I'll let you have the honors. :)<br>
<br>
Chris<br>
<br>
On 12/7/17 1:28 PM, Langer, Christoph wrote:<span \
style="font-size:12.0pt;mso-fareast-language:DE"><o:p></o:p></span></p> </div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-left:35.4pt"><span style="color:windowtext">Hi \
Chris,</span><o:p></o:p></p> <p class="MsoNormal" style="margin-left:35.4pt"><span \
style="color:windowtext"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:35.4pt"><span lang="EN-US" style="color:windowtext">ok, I \
understand. Then please let me know when you're done or …in that case you might as \
well do the push.:)</span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:35.4pt"><span lang="EN-US" \
style="color:windowtext"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:35.4pt"><span lang="EN-US" \
style="color:windowtext">Thanks</span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:35.4pt"><span lang="EN-US" \
style="color:windowtext">Christoph</span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:35.4pt"><span lang="EN-US"> </span><o:p></o:p></p> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-left:70.8pt"><b><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:DE"> Chris Plummer [<a \
href="mailto:chris.plummer@oracle.com">mailto:chris.plummer@oracle.com</a>] <br>
<b>Sent:</b> Donnerstag, 7. Dezember 2017 20:26<br>
<b>To:</b> Langer, Christoph <a \
href="mailto:christoph.langer@sap.com"><christoph.langer@sap.com></a>; <a \
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a>;
<a href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a><br>
<b>Cc:</b> Lindenmaier, Goetz <a \
href="mailto:goetz.lindenmaier@sap.com"><goetz.lindenmaier@sap.com></a><br> \
<b>Subject:</b> Re: RFR (XS): 8193183: Fix format string in \
libdt_shmem/shmemBase.c</span><o:p></o:p></p> </div>
</div>
<p class="MsoNormal" style="margin-left:70.8pt"> <o:p></o:p></p>
<div>
<p class="MsoNormal" style="margin-left:70.8pt">Hi Christoph,<br>
<br>
You can do the push, but please let me do some internal testing first. I want to make \
sure all our platforms are covered, and our closed tests are turn.<br> <br>
thanks,<br>
<br>
Chris<br>
<br>
On 12/7/17 11:02 AM, Langer, Christoph wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-left:70.8pt"><span lang="EN-US" \
style="color:windowtext">Thanks Chris and Serguei for \
reviewing.</span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:70.8pt"><span lang="EN-US" \
style="color:windowtext"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:70.8pt"><span lang="EN-US" style="color:windowtext">I can do the \
push myself as it isn't hotspot. I'll send out other webrevs tomorrow for the other \
stuff.</span><o:p></o:p></p> <p class="MsoNormal" style="margin-left:70.8pt"><span \
lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p> <p \
class="MsoNormal" style="margin-left:70.8pt"><span lang="EN-US" \
style="color:windowtext">Best regards</span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:70.8pt"><span lang="EN-US" \
style="color:windowtext">Christoph</span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:70.8pt"><span lang="EN-US"> </span><o:p></o:p></p> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-left:106.2pt"><b><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:DE"> Chris Plummer [<a \
href="mailto:chris.plummer@oracle.com">mailto:chris.plummer@oracle.com</a>] <br>
<b>Sent:</b> Donnerstag, 7. Dezember 2017 19:14<br>
<b>To:</b> Langer, Christoph <a \
href="mailto:christoph.langer@sap.com"><christoph.langer@sap.com></a>; <a \
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a><br>
<b>Cc:</b> Lindenmaier, Goetz <a \
href="mailto:goetz.lindenmaier@sap.com"><goetz.lindenmaier@sap.com></a><br> \
<b>Subject:</b> Re: RFR (XS): 8193183: Fix format string in \
libdt_shmem/shmemBase.c</span><o:p></o:p></p> </div>
</div>
<p class="MsoNormal" style="margin-left:106.2pt"> <o:p></o:p></p>
<div>
<p class="MsoNormal" style="margin-left:106.2pt">Looks good to me. I can sponsor the \
push for you.<br> <br>
thanks,<br>
<br>
Chris<br>
<br>
On 12/7/17 7:21 AM, Langer, Christoph wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-left:106.2pt">Hi,<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:106.2pt"> <o:p></o:p></p>
<p class="MsoNormal" style="margin-left:106.2pt"><span lang="EN-US">please review the \
first extracted patch from 8192978. This one is about correcting the jlong format \
string in src/jdk.jdi/share/native/libdt_shmem/shmemBase.c.</span><o:p></o:p></p> <p \
class="MsoNormal" style="margin-left:106.2pt"><span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:106.2pt"><span lang="EN-US">Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8193183"> \
https://bugs.openjdk.java.net/browse/JDK-8193183</a></span><o:p></o:p></p> <p \
class="MsoNormal" style="margin-left:106.2pt"><span lang="EN-US">WebRev: <a \
href="http://cr.openjdk.java.net/%7Eclanger/webrevs/8193183.0/"> \
http://cr.openjdk.java.net/~clanger/webrevs/8193183.0/</a></span><o:p></o:p></p> <p \
class="MsoNormal" style="margin-left:106.2pt"><span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:106.2pt"><span lang="EN-US">I believe the libdt_shmem is only \
built on windows.</span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:106.2pt"><span lang="EN-US"> </span><o:p></o:p></p> <p \
class="MsoNormal" style="margin-left:106.2pt"><span \
lang="EN-US">Thanks,</span><o:p></o:p></p> <p class="MsoNormal" \
style="margin-left:106.2pt"><span lang="EN-US">Christoph</span><o:p></o:p></p> <p \
class="MsoNormal" style="margin-left:106.2pt"><span \
lang="EN-US"> </span><o:p></o:p></p> </blockquote>
<p style="margin-left:106.2pt"> <o:p></o:p></p>
</blockquote>
<p style="margin-left:70.8pt"> <o:p></o:p></p>
</blockquote>
<p style="margin-left:35.4pt"><o:p> </o:p></p>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic