[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS): 8192840: serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java failing on Windows
From:       "Daniel D. Daugherty" <daniel.daugherty () oracle ! com>
Date:       2017-11-30 21:54:36
Message-ID: ccc8ff8c-bd61-fb59-e0c5-3ddf26c40401 () oracle ! com
[Download RAW message or body]

On 11/30/17 4:50 PM, Chris Plummer wrote:
> Hello,
>
> Please review the changes below. I'll push once I get two reviews 
> since this is an integration block and would be best if it makes it 
> into today's nightly build.

test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
        No comments.

Thumbs up.

Dan

>
> https://bugs.openjdk.java.net/browse/JDK-8192840
> diff --git 
> a/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java 
> b/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java 
>
> --- 
> a/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
> +++ 
> b/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
> @@ -37,7 +37,8 @@
>                          OutputAnalyzer output = null;
>
>                          output = executor.execute("JVMTI.agent_load " + libpath);
> -                       output.shouldContain("Agent_OnAttach is not available");
> +                       output.shouldContain("Agent_OnAttach");
> +                       output.shouldContain("is not available");
>                  } catch (Exception e) {
>                          throw new RuntimeException(e);
>                  }
>
>
> I ran the test on Windows-x64, Solaris-sparc, macosx-x64, and and 
> linux-x64 (both product and fastdebug for all 4 platforms).
>
> thanks,
>
> Chris

[prev in list] [next in list] [prev in thread] [next in thread]