[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8191564: Refactor GC related servicability code into GC specific subclasses
From:       mandy chung <mandy.chung () oracle ! com>
Date:       2017-11-30 18:41:58
Message-ID: 67b97a9b-ccd0-3232-ae4c-2a24dc9d605f () oracle ! com
[Download RAW message or body]

On 11/30/17 10:26 AM, Roman Kennke wrote:
> Hi Mandy,
>
> thanks for reviewing! I think Erik Ö. already pushed it for me.
>
>> A minor comment that GCMemoryManager could take an enum to indicate 
>> the type of this   GC action (major vs minor).     This can be a future 
>> cleanup.
>
> This may be overly restrictive: some GCs may not necessarily provide a 
> major/minor distinction, but have only one GC manager (e.g. epsilon), 
> or may provide 3 or more GC managers (e.g. 'minor' partial (or young) 
> GC, 'intermediate' concurrent GC, 'intermediate or major' concurrent 
> full GC, 'major' STW last-ditch full GC...).

Right - there will be more than 2 enums and major and major are just 
examples that could let GC notififer to determine the message based on 
the type.   This is minor and just a thought that can be considered in 
the future.

Thanks.
Mandy

[Attachment #3 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <br>
    <br>
    <div class="moz-cite-prefix">On 11/30/17 10:26 AM, Roman Kennke
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:2da42a09-73d7-6f3e-b027-337ff6ff29a2@redhat.com">Hi
      Mandy,
      <br>
      <br>
      thanks for reviewing! I think Erik Ö. already pushed it for me.
      <br>
      <br>
      <blockquote type="cite">A minor comment that GCMemoryManager could
        take an enum to indicate the type of this   GC action (major vs
        minor).     This can be a future cleanup.
        <br>
      </blockquote>
      <br>
      This may be overly restrictive: some GCs may not necessarily
      provide a major/minor distinction, but have only one GC manager
      (e.g. epsilon), or may provide 3 or more GC managers (e.g. 'minor'
      partial (or young) GC, 'intermediate' concurrent GC, 'intermediate
      or major' concurrent full GC, 'major' STW last-ditch full GC...).
      <br>
    </blockquote>
    <br>
    Right - there will be more than 2 enums and major and major are just
    examples that could let GC notififer to determine the message based
    on the type.   This is minor and just a thought that can be
    considered in the future.<br>
    <br>
    Thanks.<br>
    Mandy<br>
  </body>
</html>


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic