[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RE: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException
From: Sharath Ballal <sharath.ballal () oracle ! com>
Date: 2017-11-30 4:46:57
Message-ID: a9e96422-02fb-433e-8893-9e3097270d54 () default
[Download RAW message or body]
Hi Chris,
Thanks,
Sharath
From: Chris Plummer
Sent: Wednesday, November 29, 2017 3:05 AM
To: Sharath Ballal; serviceability-dev@openjdk.java.net
Subject: Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program \
generates NullPointerException
Hi Sharath,
Do we have any other examples of testing SA tool classes in this manner? I couldn't \
find any. I don't see any tests that directly test the classes in the \
sun/jvm/hotspot/tools. Instead I think we rely on testing the tools that use them \
such as jstack, pstack, and clhsdb. The only reference to ClassDump I could find is \
by the clhsdb buildreplayjars command.
[Sharath Ballal] Currently there are no tests to test the tools. We are writing \
tests for SA and as part of it we will write tests for other SA tools as well.
I guess was this is leading to is do we even officially support running ClassDump \
stand alone as you are doing when you reproduce this bug? If so, are there other tool \
classes that we also need better testing of.
[Sharath Ballal] I am not sure about the support. But we are trying to write \
testcases for the code that is present so that we are testing it.
I will send a separate mail with wiki links to our current SA testing strategy.
thanks,
Chris
On 11/27/17 10:15 PM, Sharath Ballal wrote:
Can I get one more review please ?
Thanks,
Sharath
From: Sharath Ballal
Sent: Wednesday, November 22, 2017 2:53 PM
To: Sundararajan Athijegannathan; HYPERLINK \
"mailto:serviceability-dev@openjdk.java.net"serviceability-dev@openjdk.java.net
Subject: RE: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program \
generates NullPointerException
Thanks Sundar.
Thanks,
Sharath
From: Sundararajan Athijegannathan
Sent: Tuesday, November 21, 2017 7:38 PM
To: HYPERLINK "mailto:serviceability-dev@openjdk.java.net"serviceability-dev@openjdk.java.net
Subject: Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program \
generates NullPointerException
+1
-Sundar
On 21/11/17, 3:26 PM, Sharath Ballal wrote:
I have made minor modification to the test (added @bug and removed @modules).
The revised webrev is
HYPERLINK "http://cr.openjdk.java.net/%7Esballal/8184982/webrev.01/"http://cr.openjdk.java.net/~sballal/8184982/webrev.01/ \
Thanks,
Sharath
From: Sharath Ballal
Sent: Tuesday, November 21, 2017 12:27 PM
To: HYPERLINK "mailto:serviceability-dev@openjdk.java.net"serviceability-dev@openjdk.java.net
Subject: RE: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program \
generates NullPointerException
Gentle reminder.
Thanks,
Sharath
From: Sharath Ballal
Sent: Tuesday, November 14, 2017 10:31 AM
To: HYPERLINK "mailto:serviceability-dev@openjdk.java.net"serviceability-dev@openjdk.java.net
Subject: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates \
NullPointerException
Hello,
Pls review the code changes and testcase for the following issue.
Bug ID: https://bugs.openjdk.java.net/browse/JDK-8184982
Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Esballal/8184982/webrev.00/"http://cr.openjdk.java.net/~sballal/8184982/webrev.00/ \
Thanks,
Sharath
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US \
link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span \
style='color:#1F497D'>Hi Chris,<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'><o:p> </o:p></span></p><div><p class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'>Thanks,<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'>Sharath<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'><o:p> </o:p></span></p></div><p \
class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span \
style='color:windowtext'> Chris Plummer <br><b>Sent:</b> Wednesday, November 29, 2017 \
3:05 AM<br><b>To:</b> Sharath Ballal; \
serviceability-dev@openjdk.java.net<br><b>Subject:</b> Re: RFR: JDK-8184982 - SA: \
Running ClassDump on a simple java program generates \
NullPointerException<o:p></o:p></span></p></div></div><p \
class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Hi Sharath,<br><br>Do we \
have any other examples of testing SA tool classes in this manner? I couldn't find \
any. I don't see any tests that directly test the classes in the \
sun/jvm/hotspot/tools. Instead I think we rely on testing the tools that use them \
such as jstack, pstack, and clhsdb. The only reference to ClassDump I could find \
is by the clhsdb buildreplayjars command.<span \
style='color:#1F497D'><o:p></o:p></span></p><p class=MsoNormal><b><i><span \
style='color:#1F497D'>[Sharath Ballal] </span></i></b><span \
style='color:#1F497D'>Currently there are no tests to test the tools. We are \
writing tests for SA and as part of it we will write tests for other SA tools as \
well.<b><i><o:p></o:p></i></b></span></p><p class=MsoNormal><br>I guess was this is \
leading to is do we even officially support running ClassDump stand alone as you are \
doing when you reproduce this bug? If so, are there other tool classes that we also \
need better testing of.<span style='color:#1F497D'><o:p></o:p></span></p><p \
class=MsoNormal><b><i><span style='color:#1F497D'>[Sharath Ballal] \
</span></i></b><span style='color:#1F497D'>I am not sure about the support. But we \
are trying to write testcases for the code that is present so that we are testing \
it.<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'>I will send a separate mail with wiki links to our current SA \
testing strategy.<b><i><o:p></o:p></i></b></span></p><p \
class=MsoNormal><br><br>thanks,<br><br>Chris<br><br>On 11/27/17 10:15 PM, Sharath \
Ballal wrote:<span style='font-size:12.0pt'><o:p></o:p></span></p></div><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span \
style='color:#1F497D'>Can I get one more review please ?</span><o:p></o:p></p><div><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'> </span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'>Thanks,</span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'>Sharath</span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'> </span><o:p></o:p></p></div><p \
class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span \
style='color:windowtext'> Sharath Ballal <br><b>Sent:</b> Wednesday, November 22, \
2017 2:53 PM<br><b>To:</b> Sundararajan Athijegannathan; <a \
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a><br><b>Subject:</b> \
RE: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates \
NullPointerException</span><o:p></o:p></p></div></div><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal><span \
style='color:#1F497D'>Thanks Sundar.</span><o:p></o:p></p><p class=MsoNormal><span \
style='color:#1F497D'> </span><o:p></o:p></p><div><p class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'> </span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'>Thanks,</span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'>Sharath</span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'> </span><o:p></o:p></p></div><p \
class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span \
style='color:windowtext'> Sundararajan Athijegannathan <br><b>Sent:</b> Tuesday, \
November 21, 2017 7:38 PM<br><b>To:</b> <a \
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a><br><b>Subject:</b> \
Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates \
NullPointerException</span><o:p></o:p></p></div></div><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>+1<br><br>-Sundar<br><br>On \
21/11/17, 3:26 PM, Sharath Ballal wrote: <o:p></o:p></p><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span \
style='color:#1F497D'>I have made minor modification to the test (added @bug and \
removed @modules).</span><o:p></o:p></p><p class=MsoNormal><span \
style='color:#1F497D'>The revised webrev is</span><o:p></o:p></p><p \
class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><p \
class=MsoNormal><span style='color:#1F497D'><a \
href="http://cr.openjdk.java.net/%7Esballal/8184982/webrev.01/">http://cr.openjdk.java.net/~sballal/8184982/webrev.01/</a> \
</span><o:p></o:p></p><p class=MsoNormal><span \
style='color:#1F497D'> </span><o:p></o:p></p><div><p class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'> </span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'>Thanks,</span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'>Sharath</span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'> </span><o:p></o:p></p></div><p \
class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b>From:</b> Sharath Ballal <br><b>Sent:</b> Tuesday, November 21, \
2017 12:27 PM<br><b>To:</b> <a \
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a><br><b>Subject:</b> \
RE: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates \
NullPointerException<o:p></o:p></p></div></div><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal><span \
style='color:#1F497D'>Gentle reminder.</span><o:p></o:p></p><p class=MsoNormal><span \
style='color:#1F497D'> </span><o:p></o:p></p><div><p class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'> </span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'>Thanks,</span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'>Sharath</span><o:p></o:p></p><p \
class=MsoNormal><span \
style='font-size:12.0pt;color:#1F497D'> </span><o:p></o:p></p></div><p \
class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b>From:</b> Sharath Ballal <br><b>Sent:</b> Tuesday, November 14, \
2017 10:31 AM<br><b>To:</b> <a \
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a><br><b>Subject:</b> \
RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates \
NullPointerException<o:p></o:p></p></div></div><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Hello,<o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Pls review the code changes \
and testcase for the following issue.<o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Bug ID: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8184982">https://bugs.openjdk.java.net/browse/JDK-8184982</a> \
<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Webrev: <a \
href="http://cr.openjdk.java.net/%7Esballal/8184982/webrev.00/">http://cr.openjdk.java.net/~sballal/8184982/webrev.00/</a> \
<o:p></o:p></p><p class=MsoNormal><span \
style='font-size:12.0pt'> </span><o:p></o:p></p><p class=MsoNormal><span \
style='font-size:12.0pt'>Thanks,</span><o:p></o:p></p><p class=MsoNormal><span \
style='font-size:12.0pt'>Sharath</span><o:p></o:p></p><p class=MsoNormal><span \
style='font-size:12.0pt'> </span><o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p></blockquote></blockquote><p><o:p> </o:p></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic