[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RE: 8189102: All tools should support -?, -h and --help
From:       "Lindenmaier, Goetz" <goetz.lindenmaier () sap ! com>
Date:       2017-11-22 17:28:09
Message-ID: 2ab914b725d54100bb5c99c1537da1df () sap ! com
[Download RAW message or body]

Hi,

I prepared a new webrev trying to incorporate all change requests:
 * I removed changes to non-english property files.
 * I removed help texts from ktab, kinit, klist
 * I removed changes to corba tools
 * I added test cases for new flags to tool specific tests (to the ones I spotted)
 * I added -help back to javac
I left the removal of -help from Javadoc, as Javadoc just prints the help message
anyways. 

New webrev:
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.03/index.html

I uploaded the parts of the patch I removed within the webrev:
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.03/help_in_property_files.patch
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.03/KinitKtabKlist_help_message.patch
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.03/corba_help_message.patch

Best regards,
  Goetz.


> -----Original Message-----
> From: serviceability-dev [mailto:serviceability-dev-
> bounces@openjdk.java.net] On Behalf Of Lindenmaier, Goetz
> Sent: Friday, November 17, 2017 12:23 PM
> To: core-libs-dev@openjdk.java.net; 'compiler-dev@openjdk.java.net'
> <compiler-dev@openjdk.java.net>; serviceability-dev (serviceability-
> dev@openjdk.java.net) <serviceability-dev@openjdk.java.net>
> Subject: RFR: 8189102: All tools should support -?, -h and --help
> 
> Hi,
> 
> please review this change. I also filed a CSR for this:
> http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.02/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189102
> CSR: https://bugs.openjdk.java.net/browse/JDK-8191477
> 
> See the webrev for a detailed description of the changes.
> 
> If required, I'll make break-out changes to be reviewed separately.
> 
> I had posted a RFR before, but improved the change to
> give a more complete overview of currently supported flags
> for the CSR:
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-
> October/028615.html
> 
> Best regards,
>   Goetz.

[prev in list] [next in list] [prev in thread] [next in thread]