[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR : JDK-8024352 - MBeanOperationInfo accepts any int value as "impact"
From: Roger Riggs <Roger.Riggs () Oracle ! com>
Date: 2017-11-15 15:11:55
Message-ID: 71766075-126c-87c1-f137-8b434b269d21 () Oracle ! com
[Download RAW message or body]
+1
On 11/15/2017 10:09 AM, Daniel Fuchs wrote:
> Hi Ujwal,
>
> Still looks good to me.
>
> best regards,
>
> -- daniel
>
> On 15/11/2017 13:18, Ujwal Vangapally wrote:
>> kindly review the updated webrev including changes to
>> MBeanInfoHashCodeNPETest.java
>>
>> webrev :
>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.05/
>>
>> Thanks,
>>
>> Ujwal.
>>
>>
>> On 11/9/2017 10:33 PM, Ujwal Vangapally wrote:
>>> Thanks for the review Mandy,
>>>
>>> kindly check if this version is better.
>>>
>>> webrev :
>>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.04/
>>>
>>> Ujwal
>>>
>>>
>>> On 11/9/2017 9:10 PM, mandy chung wrote:
>>>>
>>>>
>>>> On 11/9/17 2:40 AM, Ujwal Vangapally wrote:
>>>>> Thanks for the Review Daniel, made changes as suggested.
>>>>>
>>>>> webrev :
>>>>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.03/
>>>>>
>>>>>
>>>>
>>>> Looks good.
>>>>
>>>> Minor comment: in the new test, it can fold some of the println
>>>> together e.g. line 81 can be merged with line 39 to include the
>>>> value being passed. Similarly for the println in the main method.
>>>>
>>>> Mandy
>>>>
>>>
>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFE0">
+1<br>
<br>
<div class="moz-cite-prefix">On 11/15/2017 10:09 AM, Daniel Fuchs
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:eb95815e-6134-5009-5fa0-c00b230074e3@oracle.com">Hi
Ujwal,
<br>
<br>
Still looks good to me.
<br>
<br>
best regards,
<br>
<br>
-- daniel
<br>
<br>
On 15/11/2017 13:18, Ujwal Vangapally wrote:
<br>
<blockquote type="cite">kindly review the updated webrev including
changes to MBeanInfoHashCodeNPETest.java
<br>
<br>
webrev :
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.05/">http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.05/</a>
<br>
<br>
Thanks,
<br>
<br>
Ujwal.
<br>
<br>
<br>
On 11/9/2017 10:33 PM, Ujwal Vangapally wrote:
<br>
<blockquote type="cite">Thanks for the review Mandy,
<br>
<br>
kindly check if this version is better.
<br>
<br>
webrev :
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.04/">http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.04/</a>
<br>
<br>
Ujwal
<br>
<br>
<br>
On 11/9/2017 9:10 PM, mandy chung wrote:
<br>
<blockquote type="cite">
<br>
<br>
On 11/9/17 2:40 AM, Ujwal Vangapally wrote:
<br>
<blockquote type="cite">Thanks for the Review Daniel, made
changes as suggested.
<br>
<br>
webrev :
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.03/">http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.03/</a>
<br>
<br>
</blockquote>
<br>
Looks good.
<br>
<br>
Minor comment: in the new test, it can fold some of the
println together e.g. line 81 can be merged with line 39 to
include the value being passed. Similarly for the println
in the main method.
<br>
<br>
Mandy
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic