[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: PING: RFR: 8187401: Java Stack cannot be shown on HSDB
From: Yasumasa Suenaga <yasuenag () gmail ! com>
Date: 2017-09-29 9:28:17
Message-ID: CAGFVN2Cah6hf6tbYZ9fiRmj-mrMO-9B5bg4xb8=ONs6vfVHFuQ () mail ! gmail ! com
[Download RAW message or body]
Hi all,
This change has been reviewed by Serguei.
I'm waiting for another reviewer.
Thanks,
Yasumasa
2017/09/27 =E5=8D=88=E5=89=8D9:49 "Yasumasa Suenaga" <yasuenag@gmail.com>:
> Hi David, Serguei,
>
> I added noreg-hard label and how to reproduce to JBS:
>
> https://bugs.openjdk.java.net/browse/JDK-8187401
>
>
> Also I uploaded new webrev for jdk10/hs:
>
> http://cr.openjdk.java.net/~ysuenaga/JDK-8187401/webrev.01/
>
>
> Thanks,
>
> Yasumasa
>
>
>
> 2017-09-27 8:25 GMT+09:00 serguei.spitsyn@oracle.com
> <serguei.spitsyn@oracle.com>:
> > On 9/26/17 16:22, David Holmes wrote:
> >>
> >> On 27/09/2017 8:52 AM, serguei.spitsyn@oracle.com wrote:
> >>>
> >>> Hi David,
> >>>
> >>>
> >>> On 9/26/17 15:09, David Holmes wrote:
> >>>>
> >>>> Hi Sergeui,
> >>>>
> >>>> On 27/09/2017 3:51 AM, serguei.spitsyn@oracle.com wrote:
> >>>>>
> >>>>> Hi Yasumasa,
> >>>>>
> >>>>>
> >>>>> On 9/26/17 02:41, Yasumasa Suenaga wrote:
> >>>>>>
> >>>>>> Hi Serguei,
> >>>>>>
> >>>>>> Thank you for your comment!
> >>>>>>
> >>>>>>> This fix looks Ok to me but you need to add a unit test.
> >>>>>>
> >>>>>> I guess it is caused by inlined method which is generated by JIT
> >>>>>> compiler. I don't know how to reproduce it on jtreg test.
> >>>>>> Do you have any idea for it?
> >>>>>
> >>>>>
> >>>>> I'm not sure what exact problem you have with jtreg.
> >>>>> You may want to try to use other jtreg tests as examples.
> >>>>
> >>>>
> >>>> I see two problems:
> >>>>
> >>>> 1. hsdb is an interactive GUI tool
> >>>
> >>>
> >>> There is already at least one jtreg hsdb test:
> >>> open/test/hotspot/jtreg/serviceability/sa/JhsdbThreadInfoTest.java
> >>>
> >>> Not sure, if this example would help in this case though.
> >>>
> >>>> 2. The problem seems related to JIT inlining - so how do you force
> that
> >>>> in a test?
> >>>
> >>>
> >>> Then I wonder how was it forced in the manual reproducer?
> >>> The fact it is fixed has to be verified anyway.
> >>
> >>
> >> Well the reproducer happens to hit the issue, so we can use it to
> manually
> >> verify.
> >>
> >>>> I would think this is a noreg-hard situation. As long as there is a
> >>>> manual reproducer that can be used to verify the fix - as per the bu=
g
> report
> >>>> - that should be okay IMHO.
> >>>
> >>>
> >>> I'm Ok with adding noreg-hard label if it is hard to develop.
> >>
> >>
> >> Sounds good to me. The manual verification steps should be very clearl=
y
> >> spelt out in the bug report so that even someone unfamiliar with hsdb
> (like
> >> me!) can follow them easily.
> >
> >
> > Sounds good, thanks.
> >
> > Serguei
> >
> >>
> >> Cheers,
> >> David
> >>
> >>> Thanks,
> >>> Serguei
> >>>
> >>>> Cheers,
> >>>> David
> >>>>
> >>>>> Thanks,
> >>>>> Serguei
> >>>>>
> >>>>>> Yasumasa
> >>>>>>
> >>>>>>
> >>>>>> 2017-09-26 18:15 GMT+09:00 serguei.spitsyn@oracle.com
> >>>>>> <serguei.spitsyn@oracle.com>:
> >>>>>>>
> >>>>>>> Hi Yasumasa,
> >>>>>>>
> >>>>>>> This fix looks Ok to me but you need to add a unit test.
> >>>>>>>
> >>>>>>> Thanks,
> >>>>>>> Serguei
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> On 9/20/17 15:47, Yasumasa Suenaga wrote:
> >>>>>>>>
> >>>>>>>> PING:
> >>>>>>>>
> >>>>>>>> Have you checked this issue?
> >>>>>>>>
> >>>>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8187401/webrev.00/
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Yasumasa
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On 2017/09/11 11:16, Yasumasa Suenaga wrote:
> >>>>>>>>>
> >>>>>>>>> Hi all,
> >>>>>>>>>
> >>>>>>>>> This review request is a part of [1].
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> JBS:
> >>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8187401
> >>>>>>>>>
> >>>>>>>>> webrev:
> >>>>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8187401/webrev.00/
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> I cannot access JPRT. So I need a sponsor.
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Thanks,
> >>>>>>>>>
> >>>>>>>>> Yasumasa
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> [1]
> >>>>>>>>>
> >>>>>>>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/
> 2017-September/021821.html
> >>>>>>>>>
> >>>>>
> >>>
> >
>
[Attachment #3 (text/html)]
<div dir="auto">Hi all,<div dir="auto"><br></div><div dir="auto">This change has been \
reviewed by Serguei.</div><div dir="auto">I'm waiting for another \
reviewer.</div><div dir="auto"><br></div><div dir="auto"><br></div><div \
dir="auto">Thanks,</div><div dir="auto"><br></div><div dir="auto">Yasumasa</div><div \
dir="auto"><br></div></div><div class="gmail_extra"><br><div \
class="gmail_quote">2017/09/27 午前9:49 "Yasumasa Suenaga" <<a \
href="mailto:yasuenag@gmail.com">yasuenag@gmail.com</a>>:<br \
type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi David, Serguei,<br> <br>
I added noreg-hard label and how to reproduce to JBS:<br>
<br>
<a href="https://bugs.openjdk.java.net/browse/JDK-8187401" rel="noreferrer" \
target="_blank">https://bugs.openjdk.java.net/<wbr>browse/JDK-8187401</a><br> <br>
<br>
Also I uploaded new webrev for jdk10/hs:<br>
<br>
<a href="http://cr.openjdk.java.net/~ysuenaga/JDK-8187401/webrev.01/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~<wbr>ysuenaga/JDK-8187401/webrev.<wbr>01/</a><br>
<br>
<br>
Thanks,<br>
<br>
Yasumasa<br>
<br>
<br>
<br>
2017-09-27 8:25 GMT+09:00 <a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a><br> <<a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>>:<br> > \
On 9/26/17 16:22, David Holmes wrote:<br> >><br>
>> On 27/09/2017 8:52 AM, <a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:<br> \
>>><br> >>> Hi David,<br>
>>><br>
>>><br>
>>> On 9/26/17 15:09, David Holmes wrote:<br>
>>>><br>
>>>> Hi Sergeui,<br>
>>>><br>
>>>> On 27/09/2017 3:51 AM, <a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:<br> \
>>>>><br> >>>>> Hi Yasumasa,<br>
>>>>><br>
>>>>><br>
>>>>> On 9/26/17 02:41, Yasumasa Suenaga wrote:<br>
>>>>>><br>
>>>>>> Hi Serguei,<br>
>>>>>><br>
>>>>>> Thank you for your comment!<br>
>>>>>><br>
>>>>>>> This fix looks Ok to me but you need to add a unit \
test.<br> >>>>>><br>
>>>>>> I guess it is caused by inlined method which is \
generated by JIT<br> >>>>>> compiler. I don't know how to \
reproduce it on jtreg test.<br> >>>>>> Do you have any idea for \
it?<br> >>>>><br>
>>>>><br>
>>>>> I'm not sure what exact problem you have with jtreg.<br>
>>>>> You may want to try to use other jtreg tests as examples.<br>
>>>><br>
>>>><br>
>>>> I see two problems:<br>
>>>><br>
>>>> 1. hsdb is an interactive GUI tool<br>
>>><br>
>>><br>
>>> There is already at least one jtreg hsdb test:<br>
>>> open/test/hotspot/jtreg/<wbr>serviceability/sa/<wbr>JhsdbThreadInfoTest.java<br>
>>><br>
>>> Not sure, if this example would help in this case though.<br>
>>><br>
>>>> 2. The problem seems related to JIT inlining - so how do you force \
that<br> >>>> in a test?<br>
>>><br>
>>><br>
>>> Then I wonder how was it forced in the manual reproducer?<br>
>>> The fact it is fixed has to be verified anyway.<br>
>><br>
>><br>
>> Well the reproducer happens to hit the issue, so we can use it to \
manually<br> >> verify.<br>
>><br>
>>>> I would think this is a noreg-hard situation. As long as there is \
a<br> >>>> manual reproducer that can be used to verify the fix - as per \
the bug report<br> >>>> - that should be okay IMHO.<br>
>>><br>
>>><br>
>>> I'm Ok with adding noreg-hard label if it is hard to develop.<br>
>><br>
>><br>
>> Sounds good to me. The manual verification steps should be very clearly<br>
>> spelt out in the bug report so that even someone unfamiliar with hsdb \
(like<br> >> me!) can follow them easily.<br>
><br>
><br>
> Sounds good, thanks.<br>
><br>
> Serguei<br>
><br>
>><br>
>> Cheers,<br>
>> David<br>
>><br>
>>> Thanks,<br>
>>> Serguei<br>
>>><br>
>>>> Cheers,<br>
>>>> David<br>
>>>><br>
>>>>> Thanks,<br>
>>>>> Serguei<br>
>>>>><br>
>>>>>> Yasumasa<br>
>>>>>><br>
>>>>>><br>
>>>>>> 2017-09-26 18:15 GMT+09:00 <a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a><br> \
>>>>>> <<a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>>:<br> \
>>>>>>><br> >>>>>>> Hi Yasumasa,<br>
>>>>>>><br>
>>>>>>> This fix looks Ok to me but you need to add a unit \
test.<br> >>>>>>><br>
>>>>>>> Thanks,<br>
>>>>>>> Serguei<br>
>>>>>>><br>
>>>>>>><br>
>>>>>>><br>
>>>>>>> On 9/20/17 15:47, Yasumasa Suenaga wrote:<br>
>>>>>>>><br>
>>>>>>>> PING:<br>
>>>>>>>><br>
>>>>>>>> Have you checked this issue?<br>
>>>>>>>><br>
>>>>>>>>> <a \
href="http://cr.openjdk.java.net/~ysuenaga/JDK-8187401/webrev.00/" rel="noreferrer" \
target="_blank">http://cr.openjdk.java.net/~<wbr>ysuenaga/JDK-8187401/webrev.<wbr>00/</a><br>
>>>>>>>><br>
>>>>>>>><br>
>>>>>>>><br>
>>>>>>>> Yasumasa<br>
>>>>>>>><br>
>>>>>>>><br>
>>>>>>>> On 2017/09/11 11:16, Yasumasa Suenaga wrote:<br>
>>>>>>>>><br>
>>>>>>>>> Hi all,<br>
>>>>>>>>><br>
>>>>>>>>> This review request is a part of [1].<br>
>>>>>>>>><br>
>>>>>>>>><br>
>>>>>>>>> JBS:<br>
>>>>>>>>> <a \
href="https://bugs.openjdk.java.net/browse/JDK-8187401" rel="noreferrer" \
target="_blank">https://bugs.openjdk.java.net/<wbr>browse/JDK-8187401</a><br> \
>>>>>>>>><br> >>>>>>>>> \
webrev:<br> >>>>>>>>> <a \
href="http://cr.openjdk.java.net/~ysuenaga/JDK-8187401/webrev.00/" rel="noreferrer" \
target="_blank">http://cr.openjdk.java.net/~<wbr>ysuenaga/JDK-8187401/webrev.<wbr>00/</a><br>
>>>>>>>>><br>
>>>>>>>>><br>
>>>>>>>>> I cannot access JPRT. So I need a sponsor.<br>
>>>>>>>>><br>
>>>>>>>>><br>
>>>>>>>>> Thanks,<br>
>>>>>>>>><br>
>>>>>>>>> Yasumasa<br>
>>>>>>>>><br>
>>>>>>>>><br>
>>>>>>>>> [1]<br>
>>>>>>>>><br>
>>>>>>>>> <a \
href="http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html" \
rel="noreferrer" target="_blank">http://mail.openjdk.java.net/<wbr>pipermail/serviceability-dev/<wbr>2017-September/021821.html</a><br>
>>>>>>>>><br>
>>>>><br>
>>><br>
><br>
</blockquote></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic