[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8185003 JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument
From:       mandy chung <mandy.chung () oracle ! com>
Date:       2017-08-28 18:48:10
Message-ID: 5d28cbe1-bb2a-6f7e-9269-ab268c9a3085 () oracle ! com
[Download RAW message or body]



On 8/28/17 10:40 AM, Ujwal Vangapally wrote:
>
> kindly see the updated webrev incorporating review comments.
>
> webrev : 
> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8185003/webrev.06/
>

This version looks good.

Minor Nit:

   52                 throw new RuntimeException(" more than requested " +
   53                                          "number of frames dumped ");

line 61-62, 78, 85: leading and trailing space probably not intended.
No need for a new webrev.

Mandy
[prev in list] [next in list] [prev in thread] [next in thread]