[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RE: [8u] RFR for JDK-8169961: Memory leak after debugging session
From:       Shafi Ahmad <shafi.s.ahmad () oracle ! com>
Date:       2017-08-28 6:51:37
Message-ID: f3ad61ee-6877-4543-aaca-90659b5e5bb6 () default
[Download RAW message or body]

Thank you Serguei.

Regards,
Shafi

> -----Original Message-----
> From: Serguei Spitsyn
> Sent: Thursday, August 24, 2017 12:49 AM
> To: Shafi Ahmad <shafi.s.ahmad@oracle.com>; serviceability-
> dev@openjdk.java.net
> Cc: Langer, Christoph <christoph.langer@sap.com>; Daniel Daugherty
> <daniel.daugherty@oracle.com>
> Subject: Re: [8u] RFR for JDK-8169961: Memory leak after debugging session
> 
> Hi Shafi,
> 
> It looks good.
> 
> Thanks,
> Serguei
> 
> 
> On 8/23/17 07:34, Shafi Ahmad wrote:
> > Hi,
> >
> > Please review the backport of bug: "JDK-8169961: Memory leak after
> > debugging session" to jdk8u-dev
> >
> > Please note that this is not a clean backport due to small conflict -
> > shshahma@slc12kkg:/scratch/shshahma/Java/jdk8u-dev-base/jdk$ cat
> > src/share/classes/com/sun/tools/jdi/TargetVM.java.rej
> > --- TargetVM.java
> > +++ TargetVM.java
> > @@ -41,7 +41,7 @@
> >
> >   public class TargetVM implements Runnable {
> >       private Map<String, Packet> waitingQueue = new
> HashMap<>(32,0.75f);
> > -    private boolean shouldListen = true;
> > +    private volatile boolean shouldListen = true;
> >       private List<EventQueue> eventQueues =
> Collections.synchronizedList(new ArrayList<>(2));
> >       private VirtualMachineImpl vm;
> >       private Connection connection;
> >
> >
> > Webrev: http://cr.openjdk.java.net/~shshahma/8169961/jdk8u-
> webrev.01/
> > Jdk10 bug: https://bugs.openjdk.java.net/browse/JDK-8169961
> > Original patch pushed to jdk10:
> > http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/cbc248de6505
> >
> > Test:  Run jprt -testset core, jtreg test jdk/test/com/sun/jdi.
> >
> > Regards,
> > Shafi
> 
[prev in list] [next in list] [prev in thread] [next in thread]