[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (S) 8185687: Fix minor bugs in jvmti specification
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2017-08-24 20:28:44
Message-ID: 18696f1a-24b1-c47d-eac7-5d1db38503e9 () oracle ! com
[Download RAW message or body]

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Thank you a lot for review, Dan!<br>
      It was also reviewed by Jon Gibbons and Kumar Srinivasan.<br>
      So that, I can push it now.<br>
      <br>
      Thanks,<br>
      Serguei<br>
      <br>
      <br>
      On 8/24/17 13:25, Daniel D. Daugherty wrote:<br>
    </div>
    <blockquote
      cite="mid:795910f6-ccbe-1f4b-39ea-ee6eb7e9ab04@oracle.com"
      type="cite">
      <meta http-equiv="Context-Type" content="text/html; charset=utf-8">
      On 8/17/17 12:53 PM, <a moz-do-not-send="true"
        class="moz-txt-link-abbreviated"
        href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>
      wrote:<br>
      <blockquote type="cite"
        cite="mid:f42b19a5-8735-cb1d-48bf-c65440dcd90c@oracle.com">
        Please, review a fix for the bug:<br>
           <a class="moz-txt-link-freetext"
          href="https://bugs.openjdk.java.net/browse/JDK-8185687"
          moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8185687</a><br>
  <br>
        Webrev:<br>
           <a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2017/hotspot/8185687-jvmti-spec.1/"
                
          moz-do-not-send="true">http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8185687-jvmti-spec.1/</a><br>
  </blockquote>
      <tt>  <br>
        src/share/vm/prims/jvmti.xml<br>
               No comments.<br>
        <br>
        src/share/vm/prims/jvmti.xsl<br>
               No comments.<br>
        <br>
        Thumbs up!<br>
        <br>
        Dan<br>
        <br>
        <br>
      </tt>
      <blockquote type="cite"
        cite="mid:f42b19a5-8735-cb1d-48bf-c65440dcd90c@oracle.com"> <br>
        <br>
        Summary:<br>
        <br>
           The DocCheck utility reports 4 errors in the generated
        jvmti.html:<br>
              docs/specs/jvmti.html:38: invalid URI:
        java.net.URISyntaxException:<br>
                       llegal character in fragment at index 6: #entry point<br>
               docs/specs/jvmti.html:29721: name already declared:
        jvmtiEventCallbacks<br>
               docs/specs/jvmti.html:14895: id not found:
        AddModuleExports.to_modules<br>
              docs/specs/jvmti.html:15038: id not found:
        AddModuleOpens.to_modules<br>
        <br>
           The fixes for the first and two last errors are trivial.<br>
           But the second error for the jvmtiEventCallbacks is tricky to
        fix.<br>
           I'm not sure, this small doc issue is worth introducing extra
        complexity below to fix it.<br>
        <br>
           The jvmti.html is generated from jvmti.xml with the XSL/T
        scripts. <br>
           The issue is that two different elements with the same id (the
        attributes<br>
           'name' and 'id' are cboth considered as ids) are generated in
        the .html: <br>
               28180
&lt;td&gt;&lt;code&gt;jvmtiEventCallbacks&lt;/code&gt;&lt;/td&gt;&lt;td&gt;&lt;a
        name="jvmtiEventCallbacks"&gt;&lt;/a&gt;<br>
              29721 &lt;h4 id="jvmtiEventCallbacks"&gt;Event
        Callbacks&lt;/h4&gt;<br>
        <br>
           The matching jvmti.xml elements are:<br>
               13789 &lt;basetype id="jvmtiEventCallbacks"&gt;<br>
               11887 &lt;intro label="Event Callbacks"
        id="jvmtiEventCallbacks"&gt;<br>
        <br>
           The solution is to add optional attribute 'name' to the
        &lt;basetype&gt; XML element<br>
           and use it in the element with id="jvmtiEventCallbacks":<br>
               -       &lt;basetype id="jvmtiEventCallbacks"&gt;<br>
               +       &lt;basetype id="jvmtiEventCallbacks"
        name="eventCallbacks"&gt;<br>
        <br>
           The jvmti.xsl should use the 'name' attribute value for the
        generated element id,<br>
           if it is present, and use the 'id' attribute value otherwise.<br>
        <br>
           One more change is that that the 'name' attribute in such
        generated HTML elements<br>
           is replaced with the 'id' attribute to comply with the HTML5
        format. <br>
        <br>
        <br>
        Testing:<br>
           The nsk.jvmti and nsk.jdi tests are all passed.<br>
        <br>
           (Even though this fix is for the html errors in the spec,<br>
             it impacts the jvmti.xml that is used to produce the sources.<br>
             For instance, it replaces the 'name' attribute with the 'id'
        attribute in<br>
             several HTNL elements and renamed them to avoid the id
        duplication.)<br>
        <br>
        <br>
        Thanks,<br>
        Serguei<br>
      </blockquote>
      <br>
    </blockquote>
    <br>
  </body>
</html>


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic