[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: [10] RFR (XS): 8185930: TEST_BUG: jvmti tests should not depend on the jdk.jdi module
From: "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date: 2017-08-08 1:13:15
Message-ID: 2de1970d-c9dd-5f06-ab23-0d2b027240c2 () oracle ! com
[Download RAW message or body]
Thanks, David!
I'll push it under the trivial fix rule.
Thanks,
Serguei
On 8/7/17 18:11, David Holmes wrote:
> Seems reasonable. :)
>
> Thanks,
> David
>
> On 8/08/2017 8:21 AM, serguei.spitsyn@oracle.com wrote:
>> Please, review a two-lines fix for the bug:
>> https://bugs.openjdk.java.net/browse/JDK-8185930
>>
>> The fix is to remove the unneeded dependecies on the jdk.jdi module.
>>
>> The patch is:
>>
>> diff -r f2ec523d900b
>> test/serviceability/jvmti/GetNamedModule/MyPackage/GetNamedModuleTest.java
>> ---
>> a/test/serviceability/jvmti/GetNamedModule/MyPackage/GetNamedModuleTest.java
>> Mon Aug 07 12:34:21 2017 -0700
>> +++
>> b/test/serviceability/jvmti/GetNamedModule/MyPackage/GetNamedModuleTest.java
>> Mon Aug 07 15:12:19 2017 -0700
>> @@ -26,7 +26,6 @@
>> /**
>> * @test
>> * @summary Verifies the JVMTI GetNamedModule API
>> - * @modules jdk.jdi
>> * @compile GetNamedModuleTest.java
>> * @run main/othervm/native -agentlib:GetNamedModuleTest
>> MyPackage.GetNamedModuleTest
>> */
>> diff -r f2ec523d900b
>> test/serviceability/jvmti/IsModifiableModule/MyPackage/IsModifiableModuleTest.java
>> ---
>> a/test/serviceability/jvmti/IsModifiableModule/MyPackage/IsModifiableModuleTest.java
>> Mon Aug 07 12:34:21 2017 -0700
>> +++
>> b/test/serviceability/jvmti/IsModifiableModule/MyPackage/IsModifiableModuleTest.java
>> Mon Aug 07 15:12:19 2017 -0700
>> @@ -26,7 +26,6 @@
>> /**
>> * @test
>> * @summary Verifies the JVMTI IsModifiableModule API
>> - * @modules jdk.jdi
>> * @compile IsModifiableModuleTest.java
>> * @run main/othervm/native -agentlib:IsModifiableModuleTest
>> MyPackage.IsModifiableModuleTest
>> */
>>
>>
>> Thanks,
>> Serguei
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic