[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8185154: jdwp-protocol.html contains unescaped entities
From:       Jonathan Gibbons <jonathan.gibbons () oracle ! com>
Date:       2017-07-24 23:16:43
Message-ID: 59767FDB.4090208 () oracle ! com
[Download RAW message or body]

Thanks Dan.

Yes, in this case, I agree the udiff is probably easier to read.

-- Jon

On 07/24/2017 04:15 PM, Daniel D. Daugherty wrote:
> On 7/24/17 4:27 PM, Jonathan Gibbons wrote:
>> Please review a simple fix to escape use of the < character in HTML 
>> fragments in the JDWP spec.
>>
>> In each case, the < is simply replaced by &lt;.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8185154
>> Webrev: 
>> http://cr.openjdk.java.net/~jjg/8185154/webrev.00/make/data/jdwp/jdwp.spec.sdiff.html
>
> make/data/jdwp/jdwp.spec
>     No comments.
>
> Thumbs up.
>
> Dan
>
> P.S.
> I find the udiff easier to review for cases like this:
>
> http://cr.openjdk.java.net/~jjg/8185154/webrev.00/make/data/jdwp/jdwp.spec.udiff.html 
>
>
>>
>> -- Jon
>

[prev in list] [next in list] [prev in thread] [next in thread]