[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RE: JDK 10 RFR 8181417: Code cleanups in com.sun.jdi
From: "Langer, Christoph" <christoph.langer () sap ! com>
Date: 2017-06-16 12:18:21
Message-ID: 3f52b4f69694406991768424cb76031a () sap ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
Hi,
I just submitted http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/c0f1d48e3ffa after \
thoroughly reviewing all copyright headers, cleaning a few additional spots in the \
same sense, running a build and the jdi jtreg test suite.
Sorry for leaving this open for such a long time and the scarce initial bug \
description.
Best regards
Christoph
From: serguei.spitsyn@oracle.com [mailto:serguei.spitsyn@oracle.com]
Sent: Freitag, 2. Juni 2017 23:16
To: Langer, Christoph <christoph.langer@sap.com>; serviceability-dev@openjdk.java.net
Cc: Stuefe, Thomas <thomas.stuefe@sap.com>
Subject: Re: JDK 10 RFR 8181417: Code cleanups in com.sun.jdi
Hi Langer,
Thank you for the contribution!
It looks good (agreed with Alan on a lot of noise with the adding/removing empty \
lines). Many files (including new in this version of webrev) miss the copyright \
comment update.
Thanks,
Serguei
On 6/1/17 08:38, Langer, Christoph wrote:
Hi again,
I updated my webrev to include packages com.sun.jdi.event and com.sun.jdi.request as \
well. With that I've added everything that I found in com.sun.jdi and its \
subpackages.
Please look here: http://cr.openjdk.java.net/~clanger/webrevs/8181417.1/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8181417.1/>
Best regards
Christoph
From: Langer, Christoph
Sent: Donnerstag, 1. Juni 2017 11:40
To: serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net>; \
core-libs-dev@openjdk.java.net<mailto:core-libs-dev@openjdk.java.net>
Subject: JDK 10 RFR 8181417: Code cleanups in com.sun.jdi
Hi,
during integration work of the jdi library for one of our projects I spotted some \
places where a few cleanups could be done. I'd like to contribute this. It is mostly \
about import statements and formatting/empty lines. I think at this stage of JDK10 \
it's a good time for such kind of work.
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8181417.0/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8181417.0/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8181417
Thanks and best regards
Christoph
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US">I \
just submitted <a href="http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/c0f1d48e3ffa">http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/c0f1d48e3ffa</a> \
after thoroughly reviewing all copyright headers, cleaning a few additional spots in \
the same sense, running a build and the jdi jtreg test suite.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US">Sorry \
for leaving this open for such a long time and the scarce initial bug \
description.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US">Best \
regards<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext;mso-fareast-language:EN-US">Christoph
<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span lang="EN-US" \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></a></p> <span \
style="mso-bookmark:_MailEndCompose"></span> <div \
style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" \
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span \
lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"> \
serguei.spitsyn@oracle.com [mailto:serguei.spitsyn@oracle.com] <br>
<b>Sent:</b> Freitag, 2. Juni 2017 23:16<br>
<b>To:</b> Langer, Christoph <christoph.langer@sap.com>; \
serviceability-dev@openjdk.java.net<br> <b>Cc:</b> Stuefe, Thomas \
<thomas.stuefe@sap.com><br> <b>Subject:</b> Re: JDK 10 RFR 8181417: Code \
cleanups in com.sun.jdi<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hi Langer,<br>
<br>
Thank you for the contribution!<br>
It looks good (agreed with Alan on a lot of noise with the adding/removing empty \
lines).<br> Many files (including new in this version of webrev) miss the copyright \
comment update.<br> <br>
Thanks,<br>
Serguei<br>
<br>
<br>
<br>
On 6/1/17 08:38, Langer, Christoph wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Hi \
again,<o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US">I updated my webrev to include packages com.sun.jdi.event and \
com.sun.jdi.request as well. With that I've added everything that I found in \
com.sun.jdi and its subpackages.</span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">Please \
look here: <a href="http://cr.openjdk.java.net/%7Eclanger/webrevs/8181417.1/">http://cr.openjdk.java.net/~clanger/webrevs/8181417.1/</a></span><o:p></o:p></p>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">Best \
regards</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US">Christoph</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US"> </span><o:p></o:p></p> <div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span \
lang="EN-US">From:</span></b><span lang="EN-US"> Langer, Christoph <br>
<b>Sent:</b> Donnerstag, 1. Juni 2017 11:40<br>
<b>To:</b> <a href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a>;
<a href="mailto:core-libs-dev@openjdk.java.net">core-libs-dev@openjdk.java.net</a><br>
<b>Subject:</b> JDK 10 RFR 8181417: Code cleanups in \
com.sun.jdi</span><o:p></o:p></p> </div>
</div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Hi,<o:p></o:p></p>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US">during integration work of the jdi library for one of our projects I \
spotted some places where a few cleanups could be done. I'd like to contribute this. \
It is mostly about import statements and formatting/empty lines. I think at this \
stage of JDK10 it's a good time for such kind of work.</span><o:p></o:p></p> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">Webrev: \
<a href="http://cr.openjdk.java.net/%7Eclanger/webrevs/8181417.0/">http://cr.openjdk.java.net/~clanger/webrevs/8181417.0/</a></span><o:p></o:p></p>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8181417">https://bugs.openjdk.java.net/browse/JDK-8181417</a></span><o:p></o:p></p>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US"> </span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">Thanks \
and best regards</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US">Christoph</span><o:p></o:p></p> <div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
lang="EN-US"> </span><o:p></o:p></p> </div>
</div>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic