[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: JDK-8178508 Co-locate remaining MM tests
From: Ujwal Vangapally <ujwal.vangapally () oracle ! com>
Date: 2017-06-14 17:24:39
Message-ID: 07c2d36b-d1d3-7daa-d6ba-539539a59e8e () oracle ! com
[Download RAW message or body]
Thanks a lot for the review Mandy, Igor, Harsha .
-Ujwal.
On 6/14/2017 10:38 PM, Igor Ignatyev wrote:
> looks good to me as well.
>
> -- Igor
>> On Jun 14, 2017, at 10:06 AM, Ujwal Vangapally
>> <ujwal.vangapally@oracle.com <mailto:ujwal.vangapally@oracle.com>> wrote:
>>
>> Hi Igor can you kindly review this.
>>
>> Thanks,
>>
>> Ujwal
>>
>>
>> On 6/14/2017 9:40 AM, Mandy Chung wrote:
>>>
>>>> On Jun 13, 2017, at 8:13 PM, Ujwal Vangapally
>>>> <ujwal.vangapally@oracle.com <mailto:ujwal.vangapally@oracle.com>>
>>>> wrote:
>>>>
>>>> Thanks for the review Mandy.
>>>>
>>>> updated webrev with simplified version using @requires
>>>> os.simpleArch=="x64".
>>>>
>>>> can't use @requires (os.family != "windows") | (os.simpleArch !=
>>>> "i586")alone as sometimes it might fail on Linux 32bit as well
>>>>
>>>> webrev :
>>>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8178508/webrev.03
>>>>
>>>>
>>>
>>> This version looks good.
>>>
>>> Mandy
>>>
>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Thanks a lot for the review Mandy, Igor, Harsha .</p>
<p>-Ujwal.<br>
</p>
<br>
<div class="moz-cite-prefix">On 6/14/2017 10:38 PM, Igor Ignatyev
wrote:<br>
</div>
<blockquote
cite="mid:03FACA7B-6E6D-474D-B515-26781D6E386C@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
looks good to me as well.
<div class=""><br class="">
<div class="">-- Igor<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Jun 14, 2017, at 10:06 AM, Ujwal
Vangapally <<a moz-do-not-send="true"
href="mailto:ujwal.vangapally@oracle.com" \
class="">ujwal.vangapally@oracle.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class="">
<p class="">Hi Igor can you kindly review this.</p>
<p class="">Thanks,</p>
<p class="">Ujwal<br class="">
</p>
<br class="">
<div class="moz-cite-prefix">On 6/14/2017 9:40 AM,
Mandy Chung wrote:<br class="">
</div>
<blockquote
cite="mid:6E24B6D9-22CA-4BED-B845-6302C5562619@oracle.com"
type="cite" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
<br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On Jun 13, 2017, at 8:13 PM, Ujwal
Vangapally <<a moz-do-not-send="true"
href="mailto:ujwal.vangapally@oracle.com"
class="">ujwal.vangapally@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta content="text/html;
charset=windows-1252"
http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class="">
<p class="">Thanks for the review Mandy.</p>
<p class="">updated webrev with simplified
version using @requires
os.simpleArch=="x64".</p>
<p class="">can't use <span
style="background-color: rgb(255, 255,
255);" class="">@requires (os.family !=
"windows") | (os.simpleArch != "i586")</span><span
style="background-color: rgb(255, 255,
255);" class=""> alone as </span><span
style="background-color: rgb(255, 255,
255);" class=""><span
style="background-color: rgb(255, 255,
255);" class="">sometimes</span> it
might fail on Linux 32bit as well <br
class="">
</span></p>
<p class=""><span style="background-color:
rgb(255, 255, 255);" class="">webrev : <a
moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Euvangapally/webrev/2017/8178508/webrev.03">http://cr.openjdk.java.net/~uvangapally/webrev/2017/8178508/webrev.03</a></span></p>
<div class=""><br class="">
</div>
</div>
</div>
</blockquote>
<br class="">
</div>
<div class="">This version looks good.</div>
<div class=""><br class="">
</div>
<div class="">Mandy</div>
<br class="">
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic