[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2017-05-22 9:40:09
Message-ID: cc1fe434-af00-1ae0-9695-f92b29430a6b () oracle ! com
[Download RAW message or body]

Hello Matthias,

It is great, you are able to push this fix!

Thanks,
Serguei



On 5/22/17 01:49, Baesken, Matthias wrote:
> Hello Serguei,  the  com/sun/jdi  tests were executed ,  same number of  passed and \
> errors in a patched and unpatched JDK . We do not need a sponsor because  the \
> change is in JDK not HS . 
> Best regards, Matthias
> 
> 
> -----Original Message-----
> From: serguei.spitsyn@oracle.com [mailto:serguei.spitsyn@oracle.com]
> Sent: Freitag, 19. Mai 2017 02:18
> To: Baesken, Matthias <matthias.baesken@sap.com>; Alan Bateman \
> <Alan.Bateman@oracle.com>; core-libs-dev@openjdk.java.net; \
>                 serviceability-dev@openjdk.java.net
> Cc: Simonis, Volker <volker.simonis@sap.com>
> Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
> 
> Hi Matthias,
> 
> The fix looks good to me.
> It must be tested at least with the JTreg com/sun/jdi tests.
> Do you need a sponsor?
> 
> Thanks,
> Serguei
> 
> 
> 
> On 5/16/17 03:21, Baesken, Matthias wrote:
> > Sure, I forward it to  serviceability-dev .
> > 
> > -----Original Message-----
> > From: Alan Bateman [mailto:Alan.Bateman@oracle.com]
> > Sent: Dienstag, 16. Mai 2017 11:51
> > To: Baesken, Matthias <matthias.baesken@sap.com>; core-libs-dev@openjdk.java.net
> > Cc: Simonis, Volker <volker.simonis@sap.com>
> > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
> > 
> > 
> > 
> > On 16/05/2017 10:04, Baesken, Matthias wrote:
> > > Hello, could you please review this small change :
> > > 
> > > http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/
> > > 
> > > it fixes a number of places in   jdk.jdwp.agent   where in case of an error it \
> > > is attempted to write to NULL . 
> > > Bug :  JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
> > > 
> > > 
> > > https://bugs.openjdk.java.net/browse/JDK-8180413
> > > 
> > > 
> > Can you bring this to serviceability-dev as that is the mailing list
> > where the JDWP agent is maintained?
> > 
> > -Alan


[prev in list] [next in list] [prev in thread] [next in thread]