[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S) 8178731: compiler/ciReplay/SABase.java does not compile
From:       Dmitry Samersoff <dmitry.samersoff () oracle ! com>
Date:       2017-04-16 10:36:33
Message-ID: 6c2abd5f-6df5-e4ee-74a9-aafc0575eea0 () oracle ! com
[Download RAW message or body]

Katya,

Looks good to me.

-Dmitry

On 2017-04-15 01:54, Igor Ignatyev wrote:
> Hi Katya,
> 
> looks good to me. since it also changes svc tests, I cc'ed svc-dev alias.
> 
> Thanks,
> -- Igor
> 
>> On Apr 14, 2017, at 3:52 PM, Ekaterina Pavlova <ekaterina.pavlova@oracle.com> wrote:
>>
>> Hi everyone,
>>
>> Please review this small change that fixes hotspot/test/compiler/ciReplay/SABase.java
>> This file used ProcessHandle.getPid() which was recently renamed in ProcessHandle.pid()
>> as part of JDK-8178347.
>> Also fixed test/serviceability/sa/sadebugd/SADebugDTest.java which had the same issue.
>>
>>   bug: https://bugs.openjdk.java.net/browse/JDK-8178731
>> webrev: http://cr.openjdk.java.net/~iignatyev/epavlova/8178731/webrev.00/
>>
>> Tested by running jprt.
>>
>> thanks,
>> -katya
>>
>> p.s.
>> Igor Ignatyev volunteered to sponsor this change.
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
[prev in list] [next in list] [prev in thread] [next in thread]