[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: JDK 9 RFR of JDK-8177638: com/sun/jarsigner, jdk/internal/loader (and more) are missed in TEST.g
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2017-03-31 8:05:31
Message-ID: 8f840944-501f-13bb-1117-cb33f009a3dc () oracle ! com
[Download RAW message or body]

Hi Amy,

It looks good to me.

Thanks,
Serguei


On 3/30/17 22:42, Amy Lu wrote:
> I'm still waiting for reviewer's feedback for the TEST.groups update:
>
> jdk/internal/loader (add to jdk_lang)
> jdk/internal/util   (add to jdk_util_other)
> jdk/internal/agent  (add to jdk_management)
>
> (Security part has been reviewed. Thank you Max!)
>
> Thanks,
> Amy
>
> On 3/27/17 11:06 AM, Amy Lu wrote:
>> jdk/internal/loader
>> jdk/internal/util
>> com/sun/jarsigner
>> jdk/internal/agent
>>
>> Somehow these are missed in TEST.group.
>>
>> Please review this patch to update TEST.group
>>
>> Tested on all platforms, TestVersionedStream.java fails on Windows, 
>> put it in ProblemList.txt for now.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8177638
>> webrev: http://cr.openjdk.java.net/~amlu/8177638/webrev.00/
>>
>> Thanks,
>> Amy
>>
>>
>> --- old/test/ProblemList.txt    2017-03-27 10:57:36.000000000 +0800
>> +++ new/test/ProblemList.txt    2017-03-27 10:57:36.000000000 +0800
>> @@ -286,6 +286,7 @@
>>
>>  java/util/BitSet/BitSetStreamTest.java 8079538 generic-all
>>
>> +jdk/internal/util/jar/TestVersionedStream.java 8177640 windows-all
>>
>>  ############################################################################ 
>>
>>
>> --- old/test/TEST.groups    2017-03-27 10:57:38.000000000 +0800
>> +++ new/test/TEST.groups    2017-03-27 10:57:38.000000000 +0800
>> @@ -70,6 +70,7 @@
>>      sun/reflect \
>>      jdk/internal/reflect \
>>      jdk/lambda \
>> +    jdk/internal/loader \
>>      jdk/internal/misc \
>>      jdk/internal/ref \
>>      jdk/internal/jimage \
>> @@ -87,6 +88,7 @@
>>  jdk_util_other = \
>>      java/util \
>>      sun/util \
>> +    jdk/internal/util \
>>      -:jdk_collections \
>>      -:jdk_concurrent \
>>      -:jdk_stream
>> @@ -189,6 +191,7 @@
>>      lib/security
>>
>>  jdk_security4 = \
>> +    com/sun/jarsigner \
>>      com/sun/security/jgss \
>>      javax/security/auth/kerberos \
>>      sun/security/krb5 \
>> @@ -207,7 +210,8 @@
>>  jdk_management = \
>>      java/lang/management \
>>      com/sun/management \
>> -    sun/management
>> +    sun/management \
>> +    jdk/internal/agent
>>
>>  jdk_instrument = \
>>      java/lang/instrument
>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]