[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR : JDK-8174915 - Improve error handing for Jdp tests under sun/management/jdp
From:       Daniel Fuchs <daniel.fuchs () oracle ! com>
Date:       2017-02-21 10:21:04
Message-ID: 4143b702-ea58-b3f2-5cc5-6b87c80a746c () oracle ! com
[Download RAW message or body]

Hi Amit,

Looks good to me.
maybe you could add a comment in DynanicLauncher.java:

              // This exception is thrown by JdpTestCase.java when
              // something goes wrong. For instance, see
              // JdpTestCase::shutdown()
   62         output.shouldNotContain("java.lang.Exception:");

No need to produce a new webrev!

best regards,

-- daniel

On 20/02/17 07:22, Amit Sapre wrote:
> Hello,
>
>
>
> Please review minor improvements to jdp test helper class to handle
> error conditions.
>
>
>
> Bug ID : https://bugs.openjdk.java.net/browse/JDK-8174915
>
> Webrev :
> http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8174915/webrev.00/
>
>
>
> Thanks,
>
> Amit
>

[prev in list] [next in list] [prev in thread] [next in thread]