[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: (trivial) RFR: 8174798: Mis-merge left serviceability/sa/TestCpoolForInvokeDynamic.java ignored
From:       David Holmes <david.holmes () oracle ! com>
Date:       2017-02-13 1:20:15
Message-ID: 0840a454-9ee5-ab5b-5b0c-34af73de7e20 () oracle ! com
[Download RAW message or body]

Thanks Dan!

Pushing now.

David

On 13/02/2017 10:46 AM, Daniel D. Daugherty wrote:
> Thumbs up!
>
> Dan
>
>
>
> On 2/12/17 5:19 PM, David Holmes wrote:
>> Planning to push under trivial rules so just need one Reviewer please.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8174798
>>
>> Stumbled on this by accident. This test should no longer be ignored,
>> but somehow the removal of the @ignore was lost in a Merge.
>>
>> webrev: http://cr.openjdk.java.net/~dholmes/8174798/webrev/
>>
>> Patch below.
>>
>> Thanks,
>> David
>>
>> --- old/test/serviceability/sa/TestCpoolForInvokeDynamic.java
>> 2017-02-12 19:08:58.969198177 -0500
>> +++ new/test/serviceability/sa/TestCpoolForInvokeDynamic.java
>> 2017-02-12 19:08:57.005084892 -0500
>> @@ -1,5 +1,5 @@
>>  /*
>> - * Copyright (c) 2016, Oracle and/or its affiliates. All rights
>> reserved.
>> + * Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights
>> reserved.
>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>   *
>>   * This code is free software; you can redistribute it and/or modify it
>> @@ -51,7 +51,6 @@
>>   *          jdk.hotspot.agent/sun.jvm.hotspot.oops
>>   *          jdk.hotspot.agent/sun.jvm.hotspot.debugger
>>   *          jdk.hotspot.agent/sun.jvm.hotspot.ui.classbrowser
>> - * @ignore 8169232
>>   * @run main/othervm TestCpoolForInvokeDynamic
>>   */
>>
>
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic