[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [8u] RFR(S): Uninitialized memory in set_uintx_flag of attachListener.cpp
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2016-12-06 23:16:08
Message-ID: 356562b9-e18d-6752-171f-945650a2941f () oracle ! com
[Download RAW message or body]

Ok++

Thanks,
Serguei


On 12/6/16 05:05, David Holmes wrote:
> On 6/12/2016 9:58 PM, Dmitry Samersoff wrote:
>> Everybody,
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8170536/webrev.01/
>>
>> Please, review the fix.
>>
>> The code should return error if op->arg(1) is NULL.
>
> Looks ok. Only minor nit:
>
>  274   const char* arg1;
>  275
>  276   arg1 = op->arg(1);
>
> can be:
>
> 274   const char* arg1 = op->arg(1);
>
> Oh and copyright year needs updating.
>
> Thanks,
> David
>
>> -Dmitry
>>

[prev in list] [next in list] [prev in thread] [next in thread]