[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: JDK-8165765: javax/management/remote/mandatory/connection/RMIConnectionIdTest.java:
From: Roger Riggs <Roger.Riggs () Oracle ! com>
Date: 2016-11-29 14:41:44
Message-ID: 3e802d44-7d7b-810c-9eef-e0f3b73662c6 () Oracle ! com
[Download RAW message or body]
Hi Juwal,
Ok, thanks for the followup.
If you need a sponsor for this patch, let me know.
Roger
On 11/29/2016 4:24 AM, Ujwal Vangapally wrote:
>
> Hi Roger,
>
> I didn't verify it on a similar system as it is difficult to find one
> , instead verified by just hard coding a InetAddress different from
> which it is picking by default to String clientAddr and executed the
> test .
>
> Thanks,
> Ujwal
>
>
>
> On 11/29/2016 3:12 AM, Roger Riggs wrote:
>> Hi Ujwal,
>>
>> looks fine.
>>
>> Have you been able to verify the test on a system similar to where it
>> failed originally?
>>
>> Thanks, Roger
>>
>>
>>
>> On 11/27/2016 11:47 PM, Ujwal Vangapally wrote:
>>>
>>> gentle reminder
>>>
>>> Thanks,
>>>
>>> Ujwal
>>>
>>>
>>> On 11/24/2016 1:50 PM, Ujwal Vangapally wrote:
>>>>
>>>> Thanks for the review Roger, please find the new webrev
>>>> incorporating the review comments.
>>>>
>>>> webrev :http://cr.openjdk.java.net/~hb/sponsorship/8165765/webrev.01/
>>>>
>>>> -Ujwal
>>>>
>>>> On 11/23/2016 10:10 PM, Roger Riggs wrote:
>>>>> Hi,
>>>>>
>>>>> RMIConnectionIdTest.java:
>>>>>
>>>>> - The method NetworkInterface.getByInetAddress(addr) may be a
>>>>> better choice
>>>>> without all the looping and repetitive checks of localAddr ==
>>>>> null.
>>>>>
>>>>> Roger
>>>>>
>>>>> p.s.
>>>>>
>>>>> This would have been a good use of streams with
>>>>> NetworkInterface.networkInterfaces
>>>>> and NetworkInterface.inetAddresses.
>>>>>
>>>>>
>>>>> On 11/23/2016 4:08 AM, Ujwal Vangapally wrote:
>>>>>> Please review this small change for the bug below
>>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8165765
>>>>>>
>>>>>> Webrev:
>>>>>> http://cr.openjdk.java.net/~hb/sponsorship/8165765/webrev.00/
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Ujwal.
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFE0" text="#000000">
Hi Juwal,<br>
<br>
Ok, thanks for the followup.<br>
<br>
If you need a sponsor for this patch, let me know.<br>
<br>
Roger<br>
<br>
<br>
<div class="moz-cite-prefix">On 11/29/2016 4:24 AM, Ujwal Vangapally
wrote:<br>
</div>
<blockquote
cite="mid:34bdf08e-ac8d-9572-9118-0c45ee399a2c@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<p>Hi Roger,</p>
<p>I didn't verify it on a similar system as it is difficult to
find one , instead verified by just hard coding a InetAddress
different from which it is picking by default to String
clientAddr and executed the test .</p>
Thanks,<br>
Ujwal<br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 11/29/2016 3:12 AM, Roger Riggs
wrote:<br>
</div>
<blockquote
cite="mid:8961680e-9638-9c22-a883-71e5679a8300@Oracle.com"
type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Hi Ujwal,<br>
<br>
looks fine.<br>
<br>
Have you been able to verify the test on a system similar to
where it failed originally?<br>
<br>
Thanks, Roger<br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 11/27/2016 11:47 PM, Ujwal
Vangapally wrote:<br>
</div>
<blockquote
cite="mid:3d5f3b42-9d0f-26c1-1fb9-b3dd8f0998cf@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<p>gentle reminder <br>
</p>
<p>Thanks,</p>
<p>Ujwal<br>
</p>
<br>
<div class="moz-cite-prefix">On 11/24/2016 1:50 PM, Ujwal
Vangapally wrote:<br>
</div>
<blockquote
cite="mid:78970f02-1a5e-a369-a0df-49a174d2f0c3@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<p>Thanks for the review Roger, please find the new webrev
incorporating the review comments.</p>
<p> webrev :<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ehb/sponsorship/8165765/webrev.01/">http://cr.openjdk.java.net/~hb/sponsorship/8165765/webrev.01/</a></p>
-Ujwal<br>
<br>
<div class="moz-cite-prefix">On 11/23/2016 10:10 PM, Roger
Riggs wrote:<br>
</div>
<blockquote
cite="mid:96a739db-2193-4e63-cac9-f15d877dcca6@Oracle.com"
type="cite">Hi, <br>
<br>
RMIConnectionIdTest.java: <br>
<br>
- The method NetworkInterface.getByInetAddress(addr) may
be a better choice <br>
without all the looping and repetitive checks of
localAddr == null. <br>
<br>
Roger <br>
<br>
p.s. <br>
<br>
This would have been a good use of streams with
NetworkInterface.networkInterfaces <br>
and NetworkInterface.inetAddresses. <br>
<br>
<br>
On 11/23/2016 4:08 AM, Ujwal Vangapally wrote: <br>
<blockquote type="cite">Please review this small change
for the bug below <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8165765">https://bugs.openjdk.java.net/browse/JDK-8165765</a>
<br>
<br>
Webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ehb/sponsorship/8165765/webrev.00/">http://cr.openjdk.java.net/~hb/sponsorship/8165765/webrev.00/</a>
<br>
<br>
Thanks, <br>
<br>
Ujwal. <br>
<br>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic