[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RE: RFR: JDK-7107018: sun.jvm.hotspot.utilities.soql.JSJavaHeap.forEachClass incorrect test
From:       Jini Susan George <jini.george () oracle ! com>
Date:       2016-11-08 10:56:05
Message-ID: 034ba0fd-1ac8-41d9-83cd-eeebaa40a2e5 () default
[Download RAW message or body]

Thank you, Robbin ! 

-jini

> -----Original Message-----
> From: Robbin Ehn
> Sent: Tuesday, November 08, 2016 4:02 PM
> To: Jini Susan George; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: JDK-7107018:
> sun.jvm.hotspot.utilities.soql.JSJavaHeap.forEachClass incorrect test
> 
> Hi Jini,
> 
> Looks okay!
> 
> I personally would prefer:
> if (k != null && l != null) {
> 
> But I'll leave that up to you.
> 
> Thanks!
> 
> /Robbin ('r'eviewer)
> 
> On 11/03/2016 05:04 AM, Jini Susan George wrote:
> > Please review the trivial fix for the bug below (Unfortunately, the bug
> > is marked confidential):
> >
> >
> >
> > https://bugs.openjdk.java.net/browse/JDK-7107018
> >
> >
> >
> > Webrev:
> http://cr.openjdk.java.net/~jgeorge/7107018/webrev.00/index.html
> >
> >
> >
> > Thanks,
> >
> > - Jini Susan George
> >
> >
> >
[prev in list] [next in list] [prev in thread] [next in thread]