[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RE: RFR - JDK-8006078 : [findbugs] java.lang.management.ThreadInfo returns mutable objects
From:       Amit Sapre <amit.sapre () oracle ! com>
Date:       2016-11-03 6:08:35
Message-ID: f9338fa2-f3c0-4f31-9d43-4bfcf8829604 () default
[Download RAW message or body]

Thanks Fred for the review.

> -----Original Message-----
> From: Frederic Parain
> Sent: Wednesday, November 02, 2016 8:44 PM
> To: Amit Sapre; David Holmes; serviceability-dev
> Subject: Re: RFR - JDK-8006078 : [findbugs]
> java.lang.management.ThreadInfo returns mutable objects
> 
> Looks good to me too.
> 
> Fred
> 
> On 11/02/2016 05:58 AM, Amit Sapre wrote:
> > Hello,
> > Can I have one more review for these changes ?
> >
> >> -----Original Message-----
> >> From: David Holmes
> >> Sent: Saturday, October 29, 2016 12:22 AM
> >> To: Amit Sapre; serviceability-dev
> >> Subject: Re: RFR - JDK-8006078 : [findbugs]
> >> java.lang.management.ThreadInfo returns mutable objects
> >>
> >> Hi Amit,
> >>
> >> On 28/10/2016 4:12 PM, Amit Sapre wrote:
> >>> Hello,
> >>>
> >>> Summary : Fixed findbugs reported warnings.
> >>>
> >>> Bug ID : https://bugs.openjdk.java.net/browse/JDK-8006078
> >>>
> >>> Webrev : http://cr.openjdk.java.net/~asapre/webrev/JDK-
> >> 8006078/webrev.00/
> >>
> >> Looks okay. I hope the extra memory usage is not an issue for any
> >> tests.
> >
> > David,
> > I had run svc sanity tests only. If there are specific tests which I
> should run as well, Do let me know.
> >
> >>
> >> Thanks,
> >> David
> >>
> >>>
> >>>
> >>> Thanks,
> >>>
> >>> Amit
> >>>
[prev in list] [next in list] [prev in thread] [next in thread]