[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8168479: Backout the changes for  JDK-8168478
From:       Staffan Larsen <staffan.larsen () oracle ! com>
Date:       2016-10-21 13:48:46
Message-ID: EF849F80-D469-4838-9D05-09AF522FC939 () oracle ! com
[Download RAW message or body]

Looks good!

Thanks,
/Staffan

> On 21 Oct 2016, at 15:25, Alexander Kulyakhtin <alexander.kulyakhtin@oracle.com> \
> wrote: 
> Hi Dmitry,
> 
> Thank you very much for the review/ I've changed the CR title. 
> 
> Waiting for a (R)eviwer to approve this trivial one-line quarantine.
> 
> Best regards,
> Alexander
> 
> ----- Original Message -----
> From: dmitry.dmitriev@oracle.com
> To: alexander.kulyakhtin@oracle.com
> Cc: serviceability-dev@openjdk.java.net
> Sent: Friday, October 21, 2016 4:21:02 PM GMT +03:00 Iraq
> Subject: Re: RFR: 8168479: Backout the changes for  JDK-8168478
> 
> Hi Alexander,
> 
> can you please change bug title to "Quarantine AllModulesCommandTest.java test". \
> The change looks good. 
> Dmitry
> 
> ----- Original Message -----
> From: alexander.kulyakhtin@oracle.com
> To: serviceability-dev@openjdk.java.net
> Sent: Friday, October 21, 2016 4:10:41 PM GMT +03:00 Iraq
> Subject: RFR: 8168479: Backout the changes for  JDK-8168478
> 
> Hi,
> 
> Could you, please, review this trivial change (quarantining a test).
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8168479 "Backout the changes for \
>                 JDK-8168478"
> Webrev: http://cr.openjdk.java.net/~akulyakh/8168479/
> 
> The test is being quarantining due to \
> https://bugs.openjdk.java.net/browse/JDK-8168478 "JDWP: canRead() reports false for \
> reading from the same module 'java.base'" (same as the previously unreproducible \
> https://bugs.openjdk.java.net/browse/JDK-8166289) 
> On the SQE side we do not currently see any issues with the test itself.
> 
> Best regards,
> Alexander


[prev in list] [next in list] [prev in thread] [next in thread]