[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8164501: Uninitialised memory in byteArrayToPacket of SharedMemoryConnection.c
From:       Robbin Ehn <robbin.ehn () oracle ! com>
Date:       2016-10-21 13:22:53
Message-ID: 6aa8b320-2498-72b3-ba7c-2d0e6976aef8 () oracle ! com
[Download RAW message or body]

Thanks Staffan!

/Robbin

On 10/21/2016 03:20 PM, Staffan Larsen wrote:
> Looks good!
>
> Thanks,
> /Staffan
>
>> On 21 Oct 2016, at 14:01, Robbin Ehn <robbin.ehn@oracle.com> wrote:
>>
>> Hi again.
>>
>> Correct http webrev location should be:
>> http://cr.openjdk.java.net/~rehn/8164501/01/webrev/
>> http://cr.openjdk.java.net/~rehn/8164501/01_inc/webrev/
>>
>> /Robbin
>>
>> On 10/21/2016 01:11 PM, Robbin Ehn wrote:
>>> Hi Staffan, thanks for having a look.
>>>
>>> On 10/21/2016 11:28 AM, Staffan Larsen wrote:
>>>> Can you change:
>>>>
>>>> 185     if (total_length < 11) {
>>>>
>>>> to
>>>>
>>>> 185     if (total_length < sizeof(pktHeader) {
>>>>
>>>> ?
>>>
>>> Yes, I'll then propose changing all 11 to sizeof(pktHeader).
>>>
>>> Full: http://rehn-ws.se.oracle.com/cr_mirror/8164501/01/webrev/
>>> Inc: http://rehn-ws.se.oracle.com/cr_mirror/8164501/01_inc/webrev/
>>>
>>> /Robbin
>>>
>>>>
>>>>> On 21 Oct 2016, at 09:41, Robbin Ehn <robbin.ehn@oracle.com> wrote:
>>>>>
>>>>> Hi all, please review!
>>>>>
>>>>> This patch makes sure pktHeader is not used uninitialized and that total_length is at least 11.
>>>>> The bug is confidential, but subject and patch says alot.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8164501
>>>>> Webrev: http://cr.openjdk.java.net/~rehn/8164501/webrev/
>>>>>
>>>>> Thanks!
>>>>>
>>>>> /Robbin
>>>>
>
[prev in list] [next in list] [prev in thread] [next in thread]