[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8166289: RuntimeException: canRead() reports false for reading from the same module: expect
From:       Alexander Kulyakhtin <alexander.kulyakhtin () oracle ! com>
Date:       2016-10-18 11:40:24
Message-ID: 0a8f65e2-fef0-4efe-a0e0-fded8124b67e () default
[Download RAW message or body]

Hi Sergey,

Thank you very much for the review.

Best regards,
Alexander

----- Original Message -----
From: serguei.spitsyn@oracle.com
To: alexander.kulyakhtin@oracle.com, serviceability-dev@openjdk.java.net
Sent: Tuesday, October 18, 2016 10:31:40 AM GMT +03:00 Iraq
Subject: Re: RFR: 8166289: RuntimeException: canRead() reports false for reading from \
the same module: expected true, was false

Hi Alexander,

The fix looks good to me.
In a case the bug is reproduced again we will have some details (module 
name and ID) to understand what is wrong.

Thanks,
Serguei



On 10/17/16 06:08, Alexander Kulyakhtin wrote:
> Hi,
> 
> Could you, please, review these test-only changes
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8166289 "RuntimeException: canRead() \
>                 reports false for reading from the same module: expected true, was \
>                 false"
> Webrev: http://cr.openjdk.java.net/~akulyakh/8166289/
> 
> The fix restores the changes for https://bugs.openjdk.java.net/browse/JDK-8165017, \
> which were backed out with https://bugs.openjdk.java.net/browse/JDK-8166312, due to \
> the test failure. The test failure have never been reproduced after extensive \
> testing. This fix is trying to restore the changes adding a more correct \
> verification of the CANREAD command, as well as some additional logging in case the \
> test fails again. 
> Best regards,
> Alexander
> 


[prev in list] [next in list] [prev in thread] [next in thread]