[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8158797: Test java/lang/management/MemoryMXBean/LowMemoryTest.java fails when GC is
From:       Alexander Kulyakhtin <alexander.kulyakhtin () oracle ! com>
Date:       2016-10-13 12:43:42
Message-ID: 4b44eed0-b143-4244-83f6-be82017a7432 () default
[Download RAW message or body]

Hi Sergey,

Thank you very much for the review.

Best regards,
Alexander

----- Original Message -----
From: serguei.spitsyn@oracle.com
To: alexander.kulyakhtin@oracle.com, dmitry.samersoff@oracle.com, dmitry.dm=
itriev@oracle.com
Cc: serviceability-dev@openjdk.java.net
Sent: Thursday, October 13, 2016 3:40:37 PM GMT +03:00 Iraq
Subject: Re: RFR: 8158797: Test java/lang/management/MemoryMXBean/LowMemory=
Test.java fails when GC is specified explicitly

Alexander,

It looks good to me.

Thanks,
Serguei


On 10/13/16 05:37, Alexander Kulyakhtin wrote:
> Dmitry,
>
> Thank you very much for the review.
>
> I still need a (R)eveiwer to approve the fix. Could someone, please, revi=
ew this simple one-line change?
>
> Best regards,
> Alexander
>
> ----- Original Message -----
> From: dmitry.dmitriev@oracle.com
> To: alexander.kulyakhtin@oracle.com, serviceability-dev@openjdk.java.net
> Sent: Wednesday, October 12, 2016 5:33:45 PM GMT +03:00 Iraq
> Subject: Re: RFR: 8158797: Test java/lang/management/MemoryMXBean/LowMemo=
ryTest.java fails when GC is specified explicitly
>
> Hi Alexander,
>
> Looks good. Please correct copyright year in the header(2015 -> 2016).
> Not need a new webrev for that.
>
> Thanks,
> Dmitry
>
> On 10.10.2016 13:51, Alexander Kulyakhtin wrote:
>> Hi,
>>
>> Could you, please, review this simple, test-only change:
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8158797 "Test java/lang/man=
agement/MemoryMXBean/LowMemoryTest.java fails when GC is specified explicit=
ly"
>> Webrev: http://cr.openjdk.java.net/~akulyakh/8158797/test/java/lang/mana=
gement/MemoryMXBean/LowMemoryTest.java.udiff.html
>>
>> In order to verify some expected behavior, the test specifies its own GC=
 options when running.
>> Currently, if the testing framework runs this test with some other expli=
citly specifed GC options, then the test fails with "Conflicting collector =
combinations in option list" message.
>> We are modifying the test so that it runs only when the framework does n=
ot specify any GC options.
>>
>> Best regards,
>> Alexander


[prev in list] [next in list] [prev in thread] [next in thread]