[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS): 8167001: [TESTBUG] java/lang/instrument/DaemonThread/TestDaemonThread.java fails when r
From:       Chris Plummer <chris.plummer () oracle ! com>
Date:       2016-10-06 17:13:12
Message-ID: dc1b5c56-00b0-3c24-0491-60cc6d4b6e49 () oracle ! com
[Download RAW message or body]

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Thanks for the reviews Serguei and
      David!<br>
      <br>
      Chris<br>
      <br>
      On 10/5/16 8:22 PM, <a class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:<br>  \
</div>  <blockquote
      cite="mid:5ce016a8-79bf-fb51-4e45-6861498249c6@oracle.com"
      type="cite">
      <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
      <div class="moz-cite-prefix">Hi Chris,<br>
        <br>
        Looks good.<br>
        <br>
        Thanks,<br>
        Serguei<br>
        <br>
        <br>
        On 10/5/16 10:30, Chris Plummer wrote:<br>
      </div>
      <blockquote
        cite="mid:6b39697d-6971-0da3-c189-87a4944ce60f@oracle.com"
        type="cite">
        <meta http-equiv="Context-Type" content="text/html; ">
        <p>Hello, <br>
        </p>
        <p>[Sorry if some of you are seeing this a second time. I used
          the wrong alias the first time around]</p>
        <p>Please review the following: <br>
          <br>
          <a moz-do-not-send="true" class="moz-txt-link-freetext"
            href="https://bugs.openjdk.java.net/browse/JDK-8167001">https://bugs.openjdk.java.net/browse/JDK-8167001</a>
  <br>
          <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ecjplummer/8167001/webrev.00/webrev.jdk/">http://cr.openjdk.java.net/~cjplummer/8167001/webrev.00/webrev.jdk/</a>
  <br>
          <br>
          This fixes an issue with the classpath not being passed to the
          subprocess, resulting in the main class for the subprocess not
          being found. It only turns up when running the test with
          "agentvm", which is the default when running the test via
          test/Makefile (which is what jprt uses). "othervm" seems to be
          the default when running jtreg directly from the command line,
          so it doesn't see this problem. <br>
        </p>
        <p>It would also be possible to fix this problem by forcing the
          test to always run with othervm. However, I feel that is
          relying on a side affect of othervm and is not its intended
          purpose.   Existing tests fix this issue by explicitly passing
          the classpath to the subprocess. This is usually done by
          passing "true" as the first argument to
          ProcessTools.createJavaProcessBuilder(). This is actually the
          default behavior for hotspot/test. For jdk/test the default is
          "false" so you need to explicitly pass "true". <br>
          <br>
          Tested by running with jprt under conditions where the test
          was previously failing. Also tested by running the test
          directory locally using jdk/Makefile (which previously was
          failing). <br>
          <br>
          thanks, <br>
          <br>
          Chris </p>
      </blockquote>
      <br>
    </blockquote>
    <p><br>
    </p>
  </body>
</html>


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic