[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS): 8166806: Add intrinsic support for writer used in event based tracing
From:       Vladimir Kozlov <vladimir.kozlov () oracle ! com>
Date:       2016-10-05 18:29:12
Message-ID: 33029613-c2ba-0bc9-6a19-6e6b5a578313 () oracle ! com
[Download RAW message or body]

Looks good.

Thanks,
Vladimir

On 10/5/16 2:33 AM, Markus Gronlund wrote:
> Thanks Vladimir for taking a look,
> 
> I have done some minor updates to the webrev:
> 
> Webrev: http://cr.openjdk.java.net/~mgronlun/8166806/webrev02/
> Bug: http://bugs.openjdk.java.net/browse/JDK-8166806
> 
> The associated closed changes have been sent internally.
> 
> Thanks
> Markus
> 
> 
> -----Original Message-----
> From: Vladimir Kozlov
> Sent: den 28 september 2016 20:01
> To: Markus Gronlund; serviceability-dev@openjdk.java.net; \
>                 hotspot-compiler-dev@openjdk.java.net; Nils Eliasson
> Subject: Re: RFR(XS): 8166806: Add intrinsic support for writer used in event based \
> tracing 
> Hi Markus,
> 
> Where _getBufferWriter is defined? I don't see closed changes.
> 
> c1_LIRGenerator.cpp: should you use oopConst(NULL) in compare?
> 
> library_call.cpp: TypeInstPtr::MIRROR is useless since the result phi type is \
> TypePtr::BOTTOM. Using TypePtr::BOTTOM for load could be less bug prone. 
> Thanks,
> Vladimir
> 
> On 9/27/16 1:58 PM, Markus Gronlund wrote:
> > Greetings,
> > 
> > 
> > 
> > Kindly asking for reviews for the following change:
> > 
> > 
> > 
> > Bug: http://bugs.openjdk.java.net/browse/JDK-8166806
> > 
> > Webrev: http://cr.openjdk.java.net/~mgronlun/8166806/webrev/
> > 
> > 
> > 
> > Thanks in advance
> > 
> > Markus
> > 


[prev in list] [next in list] [prev in thread] [next in thread]