[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK
From:       Erik Gahlin <erik.gahlin () oracle ! com>
Date:       2016-09-30 16:24:08
Message-ID: 57EE91A8.9010808 () oracle ! com
[Download RAW message or body]

Looks good.

Erik

> On Sep 30, 2016, at 8:45 AM, Sergey Bylokhov <Sergey.Bylokhov@oracle.com> wrote:
> 
> Hello.
> 
> Please review the fix for jdk9.
> 
> This is request to deprecate the obsolete flags inside InputEvent. This constants \
> were marked as obsolete in jdk1.4 and were replaced by the new one. In jdk1.4 the \
> documentation were update with notion that the new constants should be used. And \
> this bug is about official deprecation of them. 
> We can replace old constants by the new one in the whole jdk, but I updated only \
> the code in InputEvent to make change smaller and safer. So at least the new code \
> in jdk and the code in applications will start to use the new constants. 
> The changes in jconsole are necessary to fix deprecation warning.
> 
> jprt build passed, no new issues were found by jck/jtreg tests.
> 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8143077
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8143077/webrev.00
> 
> -- 
> Best regards, Sergey.


[prev in list] [next in list] [prev in thread] [next in thread]