[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS): 8166806: Add intrinsic support for writer used in event based tracing
From:       Vladimir Kozlov <vladimir.kozlov () oracle ! com>
Date:       2016-09-28 18:00:53
Message-ID: 08a3d3a5-5d59-b18d-4aa6-82a2662408d3 () oracle ! com
[Download RAW message or body]

Hi Markus,

Where _getBufferWriter is defined? I don't see closed changes.

c1_LIRGenerator.cpp: should you use oopConst(NULL) in compare?

library_call.cpp: TypeInstPtr::MIRROR is useless since the result phi 
type is TypePtr::BOTTOM. Using TypePtr::BOTTOM for load could be less 
bug prone.

Thanks,
Vladimir

On 9/27/16 1:58 PM, Markus Gronlund wrote:
> Greetings,
>
>
>
> Kindly asking for reviews for the following change:
>
>
>
> Bug: http://bugs.openjdk.java.net/browse/JDK-8166806
>
> Webrev: http://cr.openjdk.java.net/~mgronlun/8166806/webrev/
>
>
>
> Thanks in advance
>
> Markus
>
[prev in list] [next in list] [prev in thread] [next in thread]