[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR (S): 8147943 jvmti.h generated with GPL header
From: "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date: 2016-09-21 8:40:24
Message-ID: e0035e0e-c073-380e-9049-3fb4fa4cb151 () oracle ! com
[Download RAW message or body]
Hi Alan,
It is a nice suggestion to use the <top>/make/templates/gpl-cp-header.
But it does not seem easy to reach it from the XSL processing.
So, I left the fix as it is.
Thanks,
Serguei
On 9/20/16 19:43, Alan Bateman wrote:
> On 20/09/2016 11:33, serguei.spitsyn@oracle.com wrote:
>> Please, review the fix for:
>> https://bugs.openjdk.java.net/browse/JDK-8147943
>>
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8147943-jvmti-header.hs1/
>>
>>
>> Summary:
>> The problem is that the
>> build/*/hotspot/variant-server/gensrc/jvmvtifiles/jvmti.h
>> is currently generated with the GPL copyright comment.
>> The JDK version of the header that we ship must have the GPL +
>> "Classpath" exception.
>> So that the file is taken from the version that is checked into the
>> jdk repository:
>> jdk/src/java.base/share/native/include/jvmti.h.
> The patch looks okay to me but I just wonder if it would be worth
> trying to consume license template from <top>/make/templates rather
> than having it in jvmtiLib.xsl - you may have looked at this ready and
> discounted it.
>
> -Alan
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Alan,<br>
<br>
It is a nice suggestion to use the
<top>/make/templates/gpl-cp-header.<br>
But it does not seem easy to reach it from the XSL processing.<br>
So, I left the fix as it is.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 9/20/16 19:43, Alan Bateman wrote:<br>
</div>
<blockquote
cite="mid:5b258094-5317-0bce-2f8e-9e5f53b99e7e@oracle.com"
type="cite">
<meta http-equiv="Context-Type" content="text/html; charset=utf-8">
On 20/09/2016 11:33, <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>
wrote:<br>
<blockquote
cite="mid:c106ba32-3a95-ff58-5129-9c74cbbe36cb@oracle.com"
type="cite"> Please, review the fix for:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8147943">https://bugs.openjdk.java.net/browse/JDK-8147943</a><br>
<br>
<br>
Webrev:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2016/hotspot/8147943-jvmti-header \
.hs1/">http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8147943-jvmti-header.hs1/</a><br>
<br>
<br>
Summary:<br>
The problem is that the
build/*/hotspot/variant-server/gensrc/jvmvtifiles/jvmti.h<br>
is currently generated with the GPL copyright comment.<br>
The JDK version of the header that we ship must have the GPL +
"Classpath" exception.<br>
So that the file is taken from the version that is checked
into the jdk repository:<br>
jdk/src/java.base/share/native/include/jvmti.h.<br>
</blockquote>
The patch looks okay to me but I just wonder if it would be worth
trying to consume license template from <top>/make/templates
rather than having it in jvmtiLib.xsl - you may have looked at
this ready and discounted it.<br>
<br>
-Alan<br>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic