[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8166202: Tracefile gensrc cannot handle closed src dir in different location
From:       Tim Bell <tim.bell () oracle ! com>
Date:       2016-09-19 14:51:17
Message-ID: 72bf5094-f7d8-fab3-f285-9c986f50160b () oracle ! com
[Download RAW message or body]

Erik:

> The xml/xsl source files used to generate sources for trace in hotspot
> have hard coded relative paths in them that make assumptions on where
> the oracle closed files are located. The source files should not make
> these kind of assumptions since that makes it difficult to change the
> repository layout structure.
>
> While this is mostly an oracle internal change, there are some light
> changes in the open makefile too. The end result should be unchanged.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8166202
>
> Webrev: http://cr.openjdk.java.net/~erikj/8166202/webrev.01/

Looks good to me.

/Tim


[prev in list] [next in list] [prev in thread] [next in thread]