[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8164913: JVMTI.agent_load dcmd should show useful error message
From:       Yasumasa Suenaga <yasuenag () gmail ! com>
Date:       2016-08-29 6:42:24
Message-ID: 7958f997-7d44-29a7-5834-1b087c7452d4 () gmail ! com
[Download RAW message or body]

> This comment no longer matches the code and should be deleted:
>
> 2412       // Agent_OnAttach executed so completion status is JNI_OK
> 2413       st->print_cr("return code: %d", result);

Thanks David!
I removed it in new webrev.

   http://cr.openjdk.java.net/~ysuenaga/JDK-8164913/webrev.01/


Yasumasa


On 2016/08/29 12:59, David Holmes wrote:
> Hi Yasumasa,
>
> On 28/08/2016 10:47 PM, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> If we try to attach invalid JVMTI agent via JVMTI.agent_load dcmd, we
>> will get
>> "Command executed successfully". However, it implies error in
>> JVMTIAgentLoadDCmd.
>>
>> This message is from JCmd.java when jcmd does not receive output from
>> target VM.
>> So we should send error message from JVMTIAgentLoadDCmd.
>>
>> I uploaded a webrev for it. Could you review it?
>>
>>   http://cr.openjdk.java.net/~ysuenaga/JDK-8164913/webrev.00/
>
> This seems reasonable.
>
> src/share/vm/prims/jvmtiExport.cpp
>
> This comment no longer matches the code and should be deleted:
>
> 2412       // Agent_OnAttach executed so completion status is JNI_OK
> 2413       st->print_cr("return code: %d", result);
>
> Thanks,
> David
>
>> I cannot access JPRT.
>> So I need a sponsor.
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
[prev in list] [next in list] [prev in thread] [next in thread]