[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: PING: RFR: JDK-8163581: Heap Parameters in HSDB cannot handle G1CollectedHeap
From:       David Holmes <david.holmes () oracle ! com>
Date:       2016-08-24 22:11:47
Message-ID: ad50369b-ed1c-8e4b-e0f0-ce67c9a9be70 () oracle ! com
[Download RAW message or body]

On 25/08/2016 12:19 AM, Yasumasa Suenaga wrote:
> Thanks Stefan!
>
> I'm waiting a second reviewer.

Stefan has covered as the GC aspect (thanks!)

I have Reviewed in the more general sense.

Thanks,
David

>
> Yasumasa
>
>
> On 2016/08/24 23:09, Stefan Johansson wrote:
>> Hi Yasumasa,
>>
>> Your change looks good. There might be more information that we want
>> to add here in the future, but this is a good start. I would
>> personally prefer the region info on its own line, but I don't have a
>> very strong opinion.
>>
>> I can sponsor the change.
>>
>> Thanks,
>> Stefan
>>
>>
>> On 2016-08-23 15:17, Yasumasa Suenaga wrote:
>>> PING: Could you review and sponsor it?
>>>
>>> Yasumasa
>>>
>>> On 2016/08/16 21:31, Yasumasa Suenaga wrote:
>>>> Hi all,
>>>>
>>>> Have you checked changes for this issue?
>>>>
>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8163581/webrev.01/hotspot/
>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8163581/webrev.01/jdk/
>>>>
>>>> For example, ParallelScavengeHeap.java overrides printOn() method.
>>>> This method shows addresses of each memory regions.
>>>>
>>>> My proposal shows memory region of G1CollectedHeap and region size.
>>>> Please review and sponsor for it. If it is not enough, please tell me.
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Yasumasa
>>>>
>>>>
>>>> On 2016/08/11 23:15, Yasumasa Suenaga wrote:
>>>>> Hi Jini,
>>>>>
>>>>> I added this check in new webrev:
>>>>>
>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8163581/webrev.01/jdk/
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Yasumasa
>>>>>
>>>>>
>>>>> On 2016/08/11 15:33, Jini Susan George wrote:
>>>>>> Thank you for this fix, Yasumasa. This issue was manifested
>>>>>> through the 'universe' command in clhsdb also, and your change
>>>>>> fixes that. It would be great if you could modify
>>>>>> BasicLauncherTest.java to have some testing done for this also.
>>>>>>
>>>>>> Thank you,
>>>>>> Jini (Not a Reviewer).
>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: David Holmes
>>>>>>> Sent: Thursday, August 11, 2016 10:03 AM
>>>>>>> To: Yasumasa Suenaga; serviceability-dev@openjdk.java.net;
>>>>>>> hotspot-gc-
>>>>>>> dev@openjdk.java.net
>>>>>>> Subject: Re: RFR: JDK-8163581: Heap Parameters in HSDB cannot handle
>>>>>>> G1CollectedHeap
>>>>>>>
>>>>>>> Hi Yasumasa,
>>>>>>>
>>>>>>> Adding in GC folk.
>>>>>>>
>>>>>>> I agree with the need to override the printOn method, but can't
>>>>>>> comment
>>>>>>> on the details of what you are actually printing.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> David
>>>>>>>
>>>>>>> On 10/08/2016 10:20 PM, Yasumasa Suenaga wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> When I chose "Heap Parameters" menu in HSDB, I got following value:
>>>>>>>> --------------------
>>>>>>>> Heap Parameters:
>>>>>>>> unknown subtype of CollectedHeap @ 0x00007f4d4c030510
>>>>>>>> (0x00000006c6e00000,0x00000007c0000000)
>>>>>>>> --------------------
>>>>>>>>
>>>>>>>> I think it should not be "unknown subtype".
>>>>>>>>
>>>>>>>> This value is shown by
>>>>>>>> sun.jvm.hotspot.gc.shared.CollectedHeap#printOn().
>>>>>>>> This method is overrided in ParallelScavengeHeap and
>>>>>>>> GenCollectedHeap.
>>>>>>>> However, G1CollectedHeap does not override.
>>>>>>>>
>>>>>>>> I think G1CollectedHeap should override this method.
>>>>>>>>
>>>>>>>> I uploaded a webrev for this issue.
>>>>>>>> Could you review it?
>>>>>>>>
>>>>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8163581/webrev.00/
>>>>>>>>
>>>>>>>> I'm jdk 9 committer, but I cannot access JPRT.
>>>>>>>> So I need a sponsor.
>>>>>>>>
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> Yasumasa
>>>>>>>>
>>
[prev in list] [next in list] [prev in thread] [next in thread]