[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8160817:Add jsadebugd functionality to jhsdb
From:       Dmitry Samersoff <dmitry.samersoff () oracle ! com>
Date:       2016-07-27 9:35:26
Message-ID: a0c6e31a-72b8-0b6a-ca3d-fe376db007fb () oracle ! com
[Download RAW message or body]

Sharath,

Looks good for me.

-Dmitry


On 2016-07-27 11:43, Sharath Ballal wrote:
> Hello,
> I figured out that the classLoaderStat functionality is already provided by 'jhsdb \
> jmap --clstats' command.  Hence I have removed the same from jhsdb in this webrev.  \
> I have updated the copyright year for the files.  I have added the GPL copyright to \
> the new file SADebugDTest.java. Pls review the same. 
> http://cr.openjdk.java.net/~sballal/8160817/webrev.02/ 
> 
> -Sharath Ballal
> 
> 
> -----Original Message-----
> From: Sharath Ballal 
> Sent: Monday, July 11, 2016 10:48 PM
> To: Dmitry Samersoff; serviceability-dev@openjdk.java.net
> Subject: RE: RFR: 8160817:Add jsadebugd and classLoaderStat functionality to jhsdb
> 
> I have updated the review by adding SADebugDTest.java
> 
> http://cr.openjdk.java.net/~sballal/8160817/webrev.01/index.html
> 
> -Sharath Ballal
> 
> 
> 
> -----Original Message-----
> From: Dmitry Samersoff
> Sent: Monday, July 11, 2016 12:45 AM
> To: Sharath Ballal; serviceability-dev@openjdk.java.net
> Subject: Re: RFR: 8160817:Add jsadebugd and classLoaderStat functionality to jhsdb
> 
> Sharath,
> 
> Looks good for me.
> 
> -Dmitry
> 
> On 2016-07-08 18:06, Sharath Ballal wrote:
> > Hello,
> > 
> > Please review the fix for:
> > 
> > JDK-8160817 <https://bugs.openjdk.java.net/browse/JDK-8160817> -  *Add 
> > jsadebugd and classLoaderStat functionality to jhsdb*
> > 
> > Webrev is at:
> > 
> > http://cr.openjdk.java.net/~sballal/8160817/webrev.00/index.html
> > 
> > 
> > 
> > This fix moves the jsadebugd and classLoaderStat functionality to 
> > jhsdb and move the TestClassLoaderStats.java functionality to 
> > BasicLauncherTest.java.
> > 
> > 
> > 
> > -Sharath Ballal
> > 
> > 
> > 
> > 
> > 
> 
> 
> --
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


[prev in list] [next in list] [prev in thread] [next in thread]