[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR:8153978:New test to verify the modules info as returned by the JVMTI
From: "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date: 2016-06-21 14:49:51
Message-ID: 5769540F.7080403 () oracle ! com
[Download RAW message or body]
Hi Christian,
Ok, thanks!
Serguei
On 6/21/16 05:11, Christian Tornqvist wrote:
>
> Hi Serguei,
>
> Yes, this is path is set in the make files/scripts that run jtreg.
>
> Thanks,
>
> Christian
>
> *From:*serguei.spitsyn@oracle.com [mailto:serguei.spitsyn@oracle.com]
> *Sent:* Tuesday, June 21, 2016 5:39 AM
> *To:* Christian Tornqvist <christian.tornqvist@oracle.com>; 'Alexander
> Kulyakhtin' <alexander.kulyakhtin@oracle.com>
> *Cc:* serviceability-dev@openjdk.java.net
> *Subject:* Re: RFR:8153978:New test to verify the modules info as
> returned by the JVMTI
>
> On 6/21/16 01:54, serguei.spitsyn@oracle.com
> <mailto:serguei.spitsyn@oracle.com> wrote:
>
> Ok, I've found how to work around my problem below.
>
> The flag -nativepath needs to be passed to the jtreg:
> -nativepath:/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/test/hotspot/jtreg/native
>
>
> Question:
> Is this flag passed when the jtreg tests are run in the nightly?
> Do I have to adjust anything in order to make new test with the
> native agent to pass in nightly?
>
> Thanks,
> Serguei
>
>
>
> Thanks,
> Serguei
>
>
> On 6/21/16 00:46, serguei.spitsyn@oracle.com
> <mailto:serguei.spitsyn@oracle.com> wrote:
>
> Hi Christian and Alexander,
>
> Not sure if my code is correct but I can not pass through the
> following agent library load error:
>
> Error occurred during initialization of VM
> Could not find agent library GetModuleByPkgTest1 on the
> library path, with error: libGetModuleByPkgTest1.so: cannot
> open shared object file: No such file or directory
>
>
> I'm using the following shell script to run my test:
>
> #!/bin/sh
>
> IMAGES=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images
> JAVA_HOME=$IMAGES/jdk
> export LD_LIBRARY_PATH=$IMAGES/test/hotspot/jtreg/native
>
> # /java/re/jtreg/4.2/nightly/binaries/jtreg/bin/jtreg \
>
> /java/re/jtreg/4.2/promoted/latest/binaries/jtreg/bin/jtreg \
> -J-Dtest.java.opts='-Xmixed -server' \
> -jdk ${JAVA_HOME} -Dtest.java.opts='-Xmixed -server' \
> /var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java
>
>
>
> The jtreg lines are:
>
> % cat -50
> test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java
> /*
> * Copyright (c) 2016, Oracle and/or its affiliates. All
> rights reserved.
> * ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to license
> terms.
> */
>
> /**
> * @test
> * @summary Verifies the JVMTI GetModuleByPackageName API
> * @compile GetModuleByPkgTest1.java
> * @run main/othervm -agentlib:GetModuleByPkgTest1
> GetModuleByPkgTest1
> */
> . . .
>
> Please, let me know if you see anything wrong in my testing
> environment.
> Below is the full .jtr log.
>
> Thanks,
> Serguei
>
> cat
> ./JTwork/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.jtr
> #Test Results (version 2)
> #Tue Jun 21 00:33:26 PDT 2016
> #checksum:265f9695e52dbedb
> #-----testdescription-----
> $file=/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java
> $root=/var/tmp/sspitsyn/jdk9/hotspot/test
> keywords=othervm
> run=USER_SPECIFIED compile
> GetModuleByPkgTest1.java\nUSER_SPECIFIED main/othervm
> -agentlib\:GetModuleByPkgTest1 GetModuleByPkgTest1\n
> source=GetModuleByPkgTest1.java
> title=Verifies the JVMTI GetModuleByPackageName API
>
> #-----environment-----
>
> #-----testresult-----
> description=file\:/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java
> elapsed=2061 0\:00\:02.061
> end=Tue Jun 21 00\:33\:26 PDT 2016
> environment=regtest
> execStatus=Failed. Unexpected exit from test [exit code\: 1]
> hostname=sc11137378.us.oracle.com
> javatestOS=Linux 3.2.0-55-generic (amd64)
> javatestVersion=4.4
> jtregVersion=jtreg 4.2 fcs b02
> script=com.sun.javatest.regtest.RegressionScript
> sections=script_messages compile build main
> start=Tue Jun 21 00\:33\:24 PDT 2016
> test=serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java
> testJDK=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk
> user.name=sspitsyn
> work=/var/tmp/sspitsyn/tst/jdk9/JTwork/serviceability/jvmti/GetModuleByPackageName
>
> #section:script_messages
> ----------messages:(5/324)----------
> JDK under test:
> /var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk
> java version "9-internal"
> Java(TM) SE Runtime Environment (fastdebug build
> 9-internal+0-2016-06-09-145126.sspitsyn.jdk9)
> Java HotSpot(TM) 64-Bit Server VM (fastdebug build
> 9-internal+0-2016-06-09-145126.sspitsyn.jdk9, mixed mode)
>
>
> #section:compile
> ----------messages:(4/233)----------
> command: compile
> /var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java
>
> reason: User specified action: run compile
> GetModuleByPkgTest1.java
> Mode: othervm
> elapsed time (seconds): 1.7
> ----------configuration:(4/227)----------
> javac compilation environment
> class path:
> /var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
>
> /var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
>
>
> ----------rerun:(21/1677)*----------
> DISPLAY=localhost:11.0 \\
> HOME=/home/sspitsyn \\
> JTREG_HOME=/java/re/jtreg/4.2/promoted/latest/binaries/jtreg \\
> LANG=en_US.UTF-8 \\
> PATH=/bin:/usr/bin \\
> /var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk/bin/javac
> \\
> -J'-Dtest.java.opts=-Xmixed -server' \\
> -J-Dtest.src=/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
> \\
> -J-Dtest.src.path=/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
> \\
> -J-Dtest.classes=/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
> \\
> -J-Dtest.class.path=/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
> \\
> -J-Dtest.vm.opts='-Dtest.java.opts=-Xmixed -server' \\
> -J-Dtest.tool.vm.opts='-J-Dtest.java.opts=-Xmixed -server' \\
> -J-Dtest.compiler.opts= \\
> -J-Dtest.java.opts= \\
> -J-Dtest.jdk=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk
> \\
> -J-Dcompile.jdk=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk
> \\
> -J-Dtest.timeout.factor=1.0 \\
> -d
> /var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
> \\
> -sourcepath
> /var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
> \\
> -classpath
> /var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName:/var \
> /tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName/va \
> r/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java
>
> ----------System.out:(0/0)----------
> ----------System.err:(0/0)----------
> result: Passed. Compilation successful
>
> #section:build
> ----------messages:(3/104)----------
> command: build GetModuleByPkgTest1
> reason: Named class compiled on demand
> elapsed time (seconds): 0.002
> result: Passed. All files up to date
>
> #section:main
> ----------messages:(4/228)----------
> command: main -agentlib:GetModuleByPkgTest1 GetModuleByPkgTest1
> reason: User specified action: run main/othervm
> -agentlib:GetModuleByPkgTest1 GetModuleByPkgTest1
> Mode: othervm [/othervm specified]
> elapsed time (seconds): 0.017
> ----------configuration:(0/0)----------
> ----------System.out:(2/210)----------
> Error occurred during initialization of VM
> Could not find agent library GetModuleByPkgTest1 on the
> library path, with error: libGetModuleByPkgTest1.so: cannot
> open shared object file: No such file or directory
> ----------System.err:(0/0)----------
> ----------rerun:(21/1756)*----------
> DISPLAY=localhost:11.0 \\
> HOME=/home/sspitsyn \\
> JTREG_HOME=/java/re/jtreg/4.2/promoted/latest/binaries/jtreg \\
> LANG=en_US.UTF-8 \\
> PATH=/bin:/usr/bin \\
> CLASSPATH=/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleBy \
> PackageName:/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPack \
> ageName:/net/scanas416.us.oracle.com/export/java_re2/misc/promoted/jtreg/4.2/fcs/b02 \
> /binaries/jtreg/lib/javatest.jar:/net/scanas416.us.oracle.com/export/java_re2/misc/promoted/jtreg/4.2/fcs/b02/binaries/jtreg/lib/jtreg.jar
> \\
> /var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk/bin/java
> \\
> -Dtest.src=/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
> \\
> -Dtest.src.path=/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
> \\
> -Dtest.classes=/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
> \\
> -Dtest.class.path=/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
> \\
> -Dtest.vm.opts='-Dtest.java.opts=-Xmixed -server' \\
> -Dtest.tool.vm.opts='-J-Dtest.java.opts=-Xmixed
> -server' \\
> -Dtest.compiler.opts= \\
> -Dtest.java.opts= \\
> -Dtest.jdk=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk
> \\
> -Dcompile.jdk=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk
> \\
> -Dtest.timeout.factor=1.0 \\
> '-Dtest.java.opts=-Xmixed -server' \\
> -agentlib:GetModuleByPkgTest1 \\
> com.sun.javatest.regtest.agent.MainWrapper
> /var/tmp/sspitsyn/tst/jdk9/JTwork/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.d/main.0.jta
>
> result: Failed. Unexpected exit from test [exit code: 1]
>
>
> test result: Failed. Unexpected exit from test [exit code: 1]
>
> Thanks,
> Serguei
>
>
> On 6/19/16 00:09, serguei.spitsyn@oracle.com
> <mailto:serguei.spitsyn@oracle.com> wrote:
>
> Hi Christian,
>
> Thank you for the reply!
> Serguei
>
>
> On 6/18/16 17:33, Christian Tornqvist wrote:
>
> Hi Serguei,
>
> We're currently using jtreg 4.2 b02, so you should be
> able to do this.
>
> Thanks,
>
> Christian
>
> *From:*serviceability-dev
> [mailto:serviceability-dev-bounces@openjdk.java.net]
> *On Behalf Of *serguei.spitsyn@oracle.com
> <mailto:serguei.spitsyn@oracle.com>
> *Sent:* Friday, June 17, 2016 7:39 PM
> *To:* Alexander Kulyakhtin
> <alexander.kulyakhtin@oracle.com>
> <mailto:alexander.kulyakhtin@oracle.com>
> *Cc:* serviceability-dev@openjdk.java.net
> <mailto:serviceability-dev@openjdk.java.net>
> *Subject:* Re: RFR:8153978:New test to verify the
> modules info as returned by the JVMTI
>
> Hi Alexander,
>
> I'm curious if the jtreg 4.2 is out and this test can
> be pushed now?
> I'd want to use the same pattern to write the Jigsaw
> related JVMTI tests.
>
> Thanks,
> Serguei
>
>
> On 5/5/16 04:25, Alexander Kulyakhtin wrote:
>
> Sergey,
>
> Thank you very much for the review.
> I will be pushing the fix as soon as jtreg 4.2 is
> out, since 4.2 has the fix for CODETOOLS-7901662,
> required for this test.
>
> Best regards,
> Alexander
>
> From: serguei.spitsyn@oracle.com
> <mailto:serguei.spitsyn@oracle.com>
> To: alexander.kulyakhtin@oracle.com
> <mailto:alexander.kulyakhtin@oracle.com>
> Cc: serviceability-dev@openjdk.java.net
> <mailto:serviceability-dev@openjdk.java.net>,
> aleksey.voytilov@oracle.com
> <mailto:aleksey.voytilov@oracle.com>
> Sent: Wednesday, May 4, 2016 11:31:07 PM GMT
> +03:00 Iraq
> Subject: Re: RFR:8153978:New test to verify the
> modules info as returned by the JVMTI
>
> Hi Alexander,
>
> It looks good.
> Thank you for making the changes!
>
> Thanks,
> Serguei
>
>
>
> On 5/4/16 05:17, Alexander Kulyakhtin wrote:
>
> Hi Sergey,
>
> Thank you very much for the review.
>
> Please, find the updated webrev with your
> findings corrected at:
> http://cr.openjdk.java.net/~akulyakh/8153978_02/index.html
> <http://cr.openjdk.java.net/%7Eakulyakh/8153978_02/index.html>
>
> Best regards,
> Alexander
>
> ----- Original Message -----
> From: serguei.spitsyn@oracle.com
> <mailto:serguei.spitsyn@oracle.com>
> To: alexander.kulyakhtin@oracle.com
> <mailto:alexander.kulyakhtin@oracle.com>,
> serviceability-dev@openjdk.java.net
> <mailto:serviceability-dev@openjdk.java.net>
> Cc: aleksey.voytilov@oracle.com
> <mailto:aleksey.voytilov@oracle.com>
> Sent: Tuesday, May 3, 2016 1:06:05 AM GMT
> +03:00 Iraq
> Subject: Re: RFR:8153978:New test to verify
> the modules info as returned by the JVMTI
>
> Hi Alexander,
>
>
> Could you, fix a couple of minor issues?
>
> test/serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java
>
> 58 for(Module mod : my.modules()) {
>
> 59 if(!jvmtiModules.contains(mod)) {
>
>
>
> A space is missed after the 'for' and 'if' keywords.
>
>
> test/serviceability/jvmti/GetModulesInfo/ModulesInfo.java.
>
> 31 boolean compareExcludingUnnamed(ModulesInfo other) {
>
>
>
> I'd suggest to call it compareNamed.
>
>
> Otherwise, the new test looks great.
> Thanks a lot for taking care about it!
>
> Thanks,
> Serguei
>
>
>
> On 4/29/16 06:12, Alexander Kulyakhtin wrote:
>
> Hi,
>
>
>
> Could you, please, review these test-only changes (adding a new test).
>
>
>
> CR:https://bugs.openjdk.java.net/browse/JDK-8153978 "New test to verify the \
> modules info as returned by the JVMTI"
> Webrev:http://cr.openjdk.java.net/~akulyakh/8153978_01/
> <http://cr.openjdk.java.net/%7Eakulyakh/8153978_01/>
>
>
>
> The new test verifies that JVMTI returns the correct info about the modules loaded \
> at the application startup.
> It also verifies that the returned info is consistent with the same info returned \
> by the Java API.
> It then loads a new named module and checks the correctness of the JVMTI info \
> again.
>
>
> Due to a tools issuehttps://bugs.openjdk.java.net/browse/CODETOOLS-7901662 the \
> test can only be pushed in when the updated jtreg is released.
> The test passes fine with the nightly jtreg build, containing the CODETOOLS-7901662 \
> fix.
>
>
> Best regards,
>
> Alexander
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Christian,<br>
<br>
Ok, thanks!<br>
Serguei<br>
<br>
<br>
On 6/21/16 05:11, Christian Tornqvist wrote:<br>
</div>
<blockquote cite="mid:af3801d1cbb6$020f5260$062df720$@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-style-priority:99;
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle23
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">Hi
Serguei,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><o:p> \
</o:p></span></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">Yes,
this is path is set in the make files/scripts that run
jtreg. <o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><o:p> \
</o:p></span></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">Christian<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><o:p> \
</o:p></span></p> <div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
<a class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>
[<a class="moz-txt-link-freetext" \
href="mailto:serguei.spitsyn@oracle.com">mailto:serguei.spitsyn@oracle.com</a>] <br> \
<b>Sent:</b> Tuesday, June 21, 2016 5:39 AM<br> <b>To:</b> Christian Tornqvist
<a class="moz-txt-link-rfc2396E" \
href="mailto:christian.tornqvist@oracle.com"><christian.tornqvist@oracle.com></a>; \
'Alexander
Kulyakhtin' <a class="moz-txt-link-rfc2396E" \
href="mailto:alexander.kulyakhtin@oracle.com"><alexander.kulyakhtin@oracle.com></a><br>
<b>Cc:</b> <a class="moz-txt-link-abbreviated" \
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: RFR:8153978:New test to verify the
modules info as returned by the JVMTI<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 6/21/16 01:54, <a
moz-do-not-send="true"
href="mailto:serguei.spitsyn@oracle.com"><a \
class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a></a> \
wrote:<o:p></o:p></p> </div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">Ok, I've found how to work around my
problem below.<br>
<br>
The flag -nativepath needs to be passed to the jtreg:<br>
-nativepath:/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/test/hotspot/jtreg/native<o:p></o:p></p>
</div>
</blockquote>
<p class="MsoNormal"><br>
Question:<br>
Is this flag passed when the jtreg tests are run in the
nightly?<br>
Do I have to adjust anything in order to make new test with
the native agent to pass in nightly?<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal"><br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 6/21/16 00:46, <a moz-do-not-send="true"
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">Hi Christian and Alexander,<br>
<br>
Not sure if my code is correct but I can not pass
through the following agent library load error:<br>
<br>
Error occurred during initialization of VM<br>
Could not find agent library GetModuleByPkgTest1 on
the library path, with error: libGetModuleByPkgTest1.so:
cannot open shared object file: No such file or
directory<br>
<br>
<br>
I'm using the following shell script to run my test:<br>
<br>
#!/bin/sh<br>
<br>
IMAGES=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images<br>
JAVA_HOME=$IMAGES/jdk<br>
export LD_LIBRARY_PATH=$IMAGES/test/hotspot/jtreg/native<br>
<br>
# /java/re/jtreg/4.2/nightly/binaries/jtreg/bin/jtreg \<br>
<br>
/java/re/jtreg/4.2/promoted/latest/binaries/jtreg/bin/jtreg
\<br>
-J-Dtest.java.opts='-Xmixed -server' \<br>
-jdk ${JAVA_HOME} -Dtest.java.opts='-Xmixed -server' \<br>
/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java<br>
<br>
<br>
<br>
The jtreg lines are:<br>
<br>
% cat -50
test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java<br>
/*<br>
* Copyright (c) 2016, Oracle and/or its affiliates. All
rights reserved.<br>
* ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to
license terms.<br>
*/<br>
<br>
/**<br>
* @test<br>
* @summary Verifies the JVMTI GetModuleByPackageName
API<br>
* @compile GetModuleByPkgTest1.java<br>
* @run main/othervm -agentlib:GetModuleByPkgTest1
GetModuleByPkgTest1<br>
*/<br>
. . .<br>
<br>
Please, let me know if you see anything wrong in my
testing environment.<br>
Below is the full .jtr log.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
cat
./JTwork/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.jtr<br>
#Test Results (version 2)<br>
#Tue Jun 21 00:33:26 PDT 2016<br>
#checksum:265f9695e52dbedb<br>
#-----testdescription-----<br>
$file=/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java<br>
$root=/var/tmp/sspitsyn/jdk9/hotspot/test<br>
keywords=othervm<br>
run=USER_SPECIFIED compile
GetModuleByPkgTest1.java\nUSER_SPECIFIED main/othervm
-agentlib\:GetModuleByPkgTest1 GetModuleByPkgTest1\n<br>
source=GetModuleByPkgTest1.java<br>
title=Verifies the JVMTI GetModuleByPackageName API<br>
<br>
#-----environment-----<br>
<br>
#-----testresult-----<br>
description=file\:/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java<br>
elapsed=2061 0\:00\:02.061<br>
end=Tue Jun 21 00\:33\:26 PDT 2016<br>
environment=regtest<br>
execStatus=Failed. Unexpected exit from test [exit
code\: 1]<br>
hostname=sc11137378.us.oracle.com<br>
javatestOS=Linux 3.2.0-55-generic (amd64)<br>
javatestVersion=4.4<br>
jtregVersion=jtreg 4.2 fcs b02<br>
script=com.sun.javatest.regtest.RegressionScript <br>
sections=script_messages compile build main<br>
start=Tue Jun 21 00\:33\:24 PDT 2016<br>
test=serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java<br>
testJDK=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk<br>
user.name=sspitsyn<br>
work=/var/tmp/sspitsyn/tst/jdk9/JTwork/serviceability/jvmti/GetModuleByPackageName<br>
<br>
#section:script_messages<br>
----------messages:(5/324)----------<br>
JDK under test:
/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk<br>
java version "9-internal"<br>
Java(TM) SE Runtime Environment (fastdebug build
9-internal+0-2016-06-09-145126.sspitsyn.jdk9)<br>
Java HotSpot(TM) 64-Bit Server VM (fastdebug build
9-internal+0-2016-06-09-145126.sspitsyn.jdk9, mixed
mode)<br>
<br>
<br>
#section:compile<br>
----------messages:(4/233)----------<br>
command: compile
/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java<br>
reason: User specified action: run compile
GetModuleByPkgTest1.java <br>
Mode: othervm<br>
elapsed time (seconds): 1.7<br>
----------configuration:(4/227)----------<br>
javac compilation environment<br>
class path:
/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
<br>
/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
<br>
<br>
----------rerun:(21/1677)*----------<br>
DISPLAY=localhost:11.0 \\<br>
HOME=/home/sspitsyn \\<br>
JTREG_HOME=/java/re/jtreg/4.2/promoted/latest/binaries/jtreg
\\<br>
LANG=en_US.UTF-8 \\<br>
PATH=/bin:/usr/bin \\<br>
/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk/bin/javac
\\<br>
-J'-Dtest.java.opts=-Xmixed -server' \\<br>
-J-Dtest.src=/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
\\<br>
-J-Dtest.src.path=/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
\\<br>
-J-Dtest.classes=/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
\\<br>
-J-Dtest.class.path=/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
\\<br>
-J-Dtest.vm.opts='-Dtest.java.opts=-Xmixed
-server' \\<br>
-J-Dtest.tool.vm.opts='-J-Dtest.java.opts=-Xmixed
-server' \\<br>
-J-Dtest.compiler.opts= \\<br>
-J-Dtest.java.opts= \\<br>
-J-Dtest.jdk=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk
\\<br>
-J-Dcompile.jdk=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk
\\<br>
-J-Dtest.timeout.factor=1.0 \\<br>
-d
/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
\\<br>
-sourcepath
/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
\\<br>
-classpath
/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName:/var/t \
mp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName/var/tm \
p/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.java<br>
----------System.out:(0/0)----------<br>
----------System.err:(0/0)----------<br>
result: Passed. Compilation successful<br>
<br>
#section:build<br>
----------messages:(3/104)----------<br>
command: build GetModuleByPkgTest1<br>
reason: Named class compiled on demand<br>
elapsed time (seconds): 0.002<br>
result: Passed. All files up to date<br>
<br>
#section:main<br>
----------messages:(4/228)----------<br>
command: main -agentlib:GetModuleByPkgTest1
GetModuleByPkgTest1<br>
reason: User specified action: run main/othervm
-agentlib:GetModuleByPkgTest1 GetModuleByPkgTest1 <br>
Mode: othervm [/othervm specified]<br>
elapsed time (seconds): 0.017<br>
----------configuration:(0/0)----------<br>
----------System.out:(2/210)----------<br>
Error occurred during initialization of VM<br>
Could not find agent library GetModuleByPkgTest1 on the
library path, with error: libGetModuleByPkgTest1.so:
cannot open shared object file: No such file or
directory<br>
----------System.err:(0/0)----------<br>
----------rerun:(21/1756)*----------<br>
DISPLAY=localhost:11.0 \\<br>
HOME=/home/sspitsyn \\<br>
JTREG_HOME=/java/re/jtreg/4.2/promoted/latest/binaries/jtreg
\\<br>
LANG=en_US.UTF-8 \\<br>
PATH=/bin:/usr/bin \\<br>
CLASSPATH=/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvm \
ti/GetModuleByPackageName:/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/Get \
ModuleByPackageName:/net/scanas416.us.oracle.com/export/java_re2/misc/promoted/jtreg/4 \
.2/fcs/b02/binaries/jtreg/lib/javatest.jar:/net/scanas416.us.oracle.com/export/java_re2/misc/promoted/jtreg/4.2/fcs/b02/binaries/jtreg/lib/jtreg.jar
\\<br>
/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk/bin/java
\\<br>
-Dtest.src=/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
\\<br>
-Dtest.src.path=/var/tmp/sspitsyn/jdk9/hotspot/test/serviceability/jvmti/GetModuleByPackageName
\\<br>
-Dtest.classes=/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
\\<br>
-Dtest.class.path=/var/tmp/sspitsyn/tst/jdk9/JTwork/classes/serviceability/jvmti/GetModuleByPackageName
\\<br>
-Dtest.vm.opts='-Dtest.java.opts=-Xmixed
-server' \\<br>
-Dtest.tool.vm.opts='-J-Dtest.java.opts=-Xmixed
-server' \\<br>
-Dtest.compiler.opts= \\<br>
-Dtest.java.opts= \\<br>
-Dtest.jdk=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk
\\<br>
-Dcompile.jdk=/var/tmp/sspitsyn/jdk9/build/linux-x86_64-normal-server-fastdebug/images/jdk
\\<br>
-Dtest.timeout.factor=1.0 \\<br>
'-Dtest.java.opts=-Xmixed -server' \\<br>
-agentlib:GetModuleByPkgTest1 \\<br>
com.sun.javatest.regtest.agent.MainWrapper
/var/tmp/sspitsyn/tst/jdk9/JTwork/serviceability/jvmti/GetModuleByPackageName/GetModuleByPkgTest1.d/main.0.jta<br>
result: Failed. Unexpected exit from test [exit code: 1]<br>
<br>
<br>
test result: Failed. Unexpected exit from test [exit
code: 1]<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 6/19/16 00:09, <a moz-do-not-send="true"
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">Hi Christian,<br>
<br>
Thank you for the reply!<br>
Serguei<br>
<br>
<br>
On 6/18/16 17:33, Christian Tornqvist wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">Hi
Serguei,</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">We're
currently using jtreg 4.2 b02, so you should be able
to do this.</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"> \
</span><o:p></o:p></p> <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">Thanks,</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">Christian</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"> \
</span><o:p></o:p></p> <div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
serviceability-dev [<a moz-do-not-send="true"
\
href="mailto:serviceability-dev-bounces@openjdk.java.net">mailto:serviceability-dev-bounces@openjdk.java.net</a>]
<b>On Behalf Of </b><a moz-do-not-send="true"
\
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a><br> \
<b>Sent:</b> Friday, June 17, 2016 7:39 PM<br> <b>To:</b> Alexander Kulyakhtin <a
moz-do-not-send="true"
href="mailto:alexander.kulyakhtin@oracle.com"><a \
class="moz-txt-link-rfc2396E" \
href="mailto:alexander.kulyakhtin@oracle.com"><alexander.kulyakhtin@oracle.com></a></a><br>
<b>Cc:</b> <a moz-do-not-send="true"
\
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: RFR:8153978:New test to
verify the modules info as returned by the \
JVMTI</span><o:p></o:p></p> </div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<div>
<p class="MsoNormal">Hi Alexander,<br>
<br>
I'm curious if the jtreg 4.2 is out and this test
can be pushed now?<br>
I'd want to use the same pattern to write the Jigsaw
related JVMTI tests.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 5/5/16 04:25, Alexander Kulyakhtin wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Sergey,<br>
<br>
Thank you very much for the review. <br>
I will be pushing the fix as soon as jtreg 4.2 is
out, since 4.2 has the fix for CODETOOLS-7901662,
required for this test.<br>
<br>
Best regards,<br>
Alexander<br>
<br>
From: <a moz-do-not-send="true"
\
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a><br> To: <a \
moz-do-not-send="true"
\
href="mailto:alexander.kulyakhtin@oracle.com">alexander.kulyakhtin@oracle.com</a><br> \
Cc: <a moz-do-not-send="true"
\
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a>,
<a moz-do-not-send="true"
\
href="mailto:aleksey.voytilov@oracle.com">aleksey.voytilov@oracle.com</a><br> Sent: \
Wednesday, May 4, 2016 11:31:07 PM GMT +03:00 Iraq<br>
Subject: Re: RFR:8153978:New test to verify the
modules info as returned by the JVMTI<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">Hi Alexander,<br>
<br>
It looks good.<br>
Thank you for making the changes!<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
<br>
On 5/4/16 05:17, Alexander Kulyakhtin wrote:<o:p></o:p></p>
</div>
<blockquote
style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal"
style="margin-bottom:12.0pt">Hi Sergey,<br>
<br>
Thank you very much for the review.<br>
<br>
Please, find the updated webrev with your
findings corrected at: <br>
<a moz-do-not-send="true"
\
href="http://cr.openjdk.java.net/%7Eakulyakh/8153978_02/index.html"
\
target="_blank">http://cr.openjdk.java.net/~akulyakh/8153978_02/index.html</a><br> \
<br> Best regards,<br>
Alexander<br>
<br>
----- Original Message -----<br>
From: <a moz-do-not-send="true"
href="mailto:serguei.spitsyn@oracle.com"
target="_blank">serguei.spitsyn@oracle.com</a><br>
To: <a moz-do-not-send="true"
href="mailto:alexander.kulyakhtin@oracle.com"
target="_blank">alexander.kulyakhtin@oracle.com</a>,
<a moz-do-not-send="true"
\
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a><br>
Cc: <a moz-do-not-send="true"
href="mailto:aleksey.voytilov@oracle.com"
target="_blank">aleksey.voytilov@oracle.com</a><br>
Sent: Tuesday, May 3, 2016 1:06:05 AM GMT
+03:00 Iraq<br>
Subject: Re: RFR:8153978:New test to verify
the modules info as returned by the JVMTI<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">Hi Alexander,<br>
<br>
<br>
Could you, fix a couple of minor issues?<br>
<br>
test/serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java<o:p></o:p></p>
<pre> 58 for(Module mod : \
my.modules()) {<o:p></o:p></pre>
<pre> 59 \
if(!jvmtiModules.contains(mod)) {<o:p></o:p></pre> <pre> <o:p></o:p></pre>
<pre> A space is missed after the 'for' and 'if' \
keywords.<o:p></o:p></pre> <p class="MsoNormal"><br>
test/serviceability/jvmti/GetModulesInfo/ModulesInfo.java.<o:p></o:p></p>
<pre> 31 boolean \
compareExcludingUnnamed(ModulesInfo other) {<o:p></o:p></pre> <pre> \
<o:p></o:p></pre>
<pre> I'd suggest to call it \
compareNamed.<o:p></o:p></pre> <p class="MsoNormal"><br>
Otherwise, the new test looks great.<br>
Thanks a lot for taking care about it!<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
<br>
On 4/29/16 06:12, Alexander Kulyakhtin
wrote:<o:p></o:p></p>
</div>
<blockquote
style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre>Hi, <o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>Could you, please, review these test-only changes \
(adding a new test).<o:p></o:p></pre> <pre> <o:p></o:p></pre>
<pre>CR: <a moz-do-not-send="true" \
href="https://bugs.openjdk.java.net/browse/JDK-8153978" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8153978</a> "New test to \
verify the modules info as returned by the JVMTI"<o:p></o:p></pre> <pre>Webrev: <a \
moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Eakulyakh/8153978_01/" \
target="_blank">http://cr.openjdk.java.net/~akulyakh/8153978_01/</a><o:p></o:p></pre> \
<pre> <o:p></o:p></pre>
<pre>The new test verifies that JVMTI returns the \
correct info about the modules loaded at the application startup. \
<o:p></o:p></pre>
<pre>It also verifies that the returned info is \
consistent with the same info returned by the Java \
API.<o:p></o:p></pre>
<pre>It then loads a new named module and checks the \
correctness of the JVMTI info again.<o:p></o:p></pre> <pre> <o:p></o:p></pre>
<pre>Due to a tools issue <a moz-do-not-send="true" \
href="https://bugs.openjdk.java.net/browse/CODETOOLS-7901662" \
target="_blank">https://bugs.openjdk.java.net/browse/CODETOOLS-7901662</a> the test \
can only be pushed in when the updated jtreg is \
released.<o:p></o:p></pre>
<pre>The test passes fine with the nightly jtreg build, \
containing the CODETOOLS-7901662 fix.<o:p></o:p></pre> <pre> <o:p></o:p></pre>
<pre>Best regards,<o:p></o:p></pre>
<pre>Alexander<o:p></o:p></pre>
</blockquote>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
</blockquote>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
</blockquote>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic