[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S): JDK-8152950 BasicLauncherTest.java fails due to type error
From:       Jaroslav Bachorik <j.bachorik () gmail ! com>
Date:       2016-05-26 16:52:08
Message-ID: CAJBAviv0jgzM6SUu4P8=j2shHVqM2uwrKqmtEa9eD3PcSr5e6A () mail ! gmail ! com
[Download RAW message or body]

Hi Dmitry,

#
http://cr.openjdk.java.net/~dsamersoff/JDK-8152950/webrev.03/hotspot_webrev/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java.sdiff.html
 L1752 - wording 'some commands is not available' -> 'some commands will not
be available'

#
http://cr.openjdk.java.net/~dsamersoff/JDK-8152950/webrev.03/jdk_webrev/test/sun/tools/jhsdb/BasicLauncherTest.java.sdiff.html
 L100 - I believe it should not say 'Test FAILED'; maybe just 'FAILED'?

Other than that the changes look good.

Cheers,

-JB-

On Thu, May 26, 2016 at 2:12 PM, Dmitry Samersoff <
dmitry.samersoff@oracle.com> wrote:

> Everybody,
> 
> Please review the fix.
> 
> http://cr.openjdk.java.net/~dsamersoff/JDK-8152950/webrev.03/
> 
> This fix cleanup the test and improve error handling in CLHSDB launcher.
> 
> The root of the problem is that in modular world nashhorn can't access
> module internal packages ever if they are public. (see details in bug
> report).
> 
> Complete fix requires significant efforts and it will be done under
> separate CR (JDK-8157947).
> 
> -Dmitry
> 
> --
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.
> 


[Attachment #3 (text/html)]

<div dir="ltr">Hi Dmitry,<div><br></div><div># <a \
href="http://cr.openjdk.java.net/~dsamersoff/JDK-8152950/webrev.03/hotspot_webrev/src/ \
jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java.sdiff.html">http \
://cr.openjdk.java.net/~dsamersoff/JDK-8152950/webrev.03/hotspot_webrev/src/jdk.hotspo \
t.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java.sdiff.html</a></div><div>L1752 \
- wording &#39;some commands is not available&#39; -&gt; &#39;some commands will not \
be available&#39;</div><div><br>#  <a \
href="http://cr.openjdk.java.net/~dsamersoff/JDK-8152950/webrev.03/jdk_webrev/test/sun \
/tools/jhsdb/BasicLauncherTest.java.sdiff.html">http://cr.openjdk.java.net/~dsamersoff \
/JDK-8152950/webrev.03/jdk_webrev/test/sun/tools/jhsdb/BasicLauncherTest.java.sdiff.html</a></div><div>L100 \
- I believe it should not say &#39;Test FAILED&#39;; maybe just \
&#39;FAILED&#39;?<br><br>Other than that the changes look \
good.</div><div><br></div><div>Cheers,</div><div><br></div><div>-JB-</div></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Thu, May 26, 2016 at 2:12 PM, \
Dmitry Samersoff <span dir="ltr">&lt;<a href="mailto:dmitry.samersoff@oracle.com" \
target="_blank">dmitry.samersoff@oracle.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Everybody,<br> <br>
Please review the fix.<br>
<br>
<a href="http://cr.openjdk.java.net/~dsamersoff/JDK-8152950/webrev.03/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~dsamersoff/JDK-8152950/webrev.03/</a><br>
 <br>
This fix cleanup the test and improve error handling in CLHSDB launcher.<br>
<br>
The root of the problem is that in modular world nashhorn can&#39;t access<br>
module internal packages ever if they are public. (see details in bug<br>
report).<br>
<br>
Complete fix requires significant efforts and it will be done under<br>
separate CR (JDK-8157947).<br>
<span class="HOEnZb"><font color="#888888"><br>
-Dmitry<br>
<br>
--<br>
Dmitry Samersoff<br>
Oracle Java development team, Saint Petersburg, Russia<br>
* I would love to change the world, but they won&#39;t give me the sources.<br>
</font></span></blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]