[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: 8154985: Add the ability to use main class as lookup (as jcmd) to jinfo, jmap, jstack
From:       Robbin Ehn <robbin.ehn () oracle ! com>
Date:       2016-05-09 20:20:55
Message-ID: 5b91affa-c162-838b-5998-f633c75c853b () oracle ! com
[Download RAW message or body]

Hi Dmitry,

Thanks!

On 05/09/2016 10:18 PM, Dmitry Samersoff wrote:
> Robbin,
>
> Looks good for me.
>
> Did you test the situation when more than one pid returned ?
Yes!

I actually had test for that but it had same name as yours, so it was 
overwritten.

I'll add it back after FC (and a few more tests).

/Robbin

>
> -Dmitry
>
> On 2016-05-09 17:10, Robbin Ehn wrote:
>> Hi all,
>>
>> Please review this enhancement for jinfo, jstack and jmap.
>>
>> It is based on top of "8155091: Remove SA related functions from tmtools"
>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-May/019609.html
>>
>> Version 5 which is reviewed but not yet pushed:
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.05/
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154985
>> Webrev: http://cr.openjdk.java.net/~rehn/8154985/webrev/
>>
>> Passes jdk/test/sun/tools/
>> (or 1 test fails locally, but that tests also fails in vanilla)
>> And manual testing.
>>
>> Thanks!
>>
>> /Robbin
>
>
[prev in list] [next in list] [prev in thread] [next in thread]