[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(M): v.04, 8155091: Remove SA related functions from tmtools
From:       Dmitry Samersoff <dmitry.samersoff () oracle ! com>
Date:       2016-05-05 19:51:58
Message-ID: 572BA45E.1090905 () oracle ! com
[Download RAW message or body]

Mandy,

OK. Will change it.

Thank you for review!

-Dmitry


On 2016-05-05 22:48, Mandy Chung wrote:
> 
> > On May 5, 2016, at 5:51 AM, Dmitry Samersoff <dmitry.samersoff@oracle.com> wrote:
> > 
> > Please, see updated webrev.
> > 
> > http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.04/
> 
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/ToolProvider.java
> I suggest to remove this as jdk.hotspot.agent is no longer a provider.  You could \
> keep the getName and run methods and just remove @Override annotation. 
> I only skimmed on the jdk change. 
> 
> test/sun/tools/jinfo/BasicJInfoTest.java
> It has @bug 6260070 (an old bug).   Is it renamed from an existing test? OR just \
> cut-n-paste error. 
> 35  * @modules java.management
> 
> Is this still needed?
> 
> test/sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java and other jhsdb tests
> should have @modules jdk.hotspot.agent
> 
> Mandy
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


[prev in list] [next in list] [prev in thread] [next in thread]