[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8156133: FindCrashesAction in HSDB does not work except Solaris platform
From:       Dmitry Samersoff <dmitry.samersoff () oracle ! com>
Date:       2016-05-05 17:59:01
Message-ID: 572B89E5.90502 () oracle ! com
[Download RAW message or body]

Yasumasa,

The fix looks good for me.

I'll sponsor the push.

-Dmitry

On 2016-05-05 15:32, Yasumasa Suenaga wrote:
> Hi all,
> 
> HSDB can find crash thread from core image.
> However, it works on Solaris only.
> 
> JavaThreadsPanel#fireShowThreadCrashes() detects as crashed thread
> from JavaThreads which has signal handler frame.
> Signal handler frame is different by platform. Thus it is hard to
> implement Frame#isSignalHandlerFrameDbg() for each platforms.
> 
> As one of solution, I propose to add pointer of crashed JavaThread
> to VMStructs.
> Originally, this feature seems to work for crashing with dumping
> hs_err log. If so, this proposal does not change behavior.
> 
> I uploaded a webrev for this issue.
> Could you review it?
> 
>   http://cr.openjdk.java.net/~ysuenaga/JDK-8156133/webrev.00/
> 
> I cannot access JPRT.
> So I need a sponsor.
> 
> 
> Thanks,
> 
> Yasumasa


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
[prev in list] [next in list] [prev in thread] [next in thread]