[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS) 8155727: java/util/concurrent/locks/Lock/TimedAcquireLeak.java timeouts.
From:       David Holmes <david.holmes () oracle ! com>
Date:       2016-04-29 23:04:01
Message-ID: a003294d-bf73-4c9b-9d1d-c60b0de7b45b () oracle ! com
[Download RAW message or body]

On 30/04/2016 5:39 AM, Martin Buchholz wrote:
> Thanks, looks good.
>
> (In future, please notify code owners using the relevant mailing
> lists, in this case core-libs-dev)

Harold was given incorrect information as to the owning area in this case.

Cheers,
David

> On Fri, Apr 29, 2016 at 12:32 PM, harold seigel
> <harold.seigel@oracle.com> wrote:
>> Please review this updated webrev that uses Martin's fix:
>>
>> New webrev: http://cr.openjdk.java.net/~hseigel/bug_8155727.1/
>>
>> Thanks, Harold
>>
>>
>> On 4/29/2016 3:19 PM, Martin Buchholz wrote:
>>>
>>> Apologies for taking over here ... This test is maintained externally
>>> in JSR166 CVS.  We prefer a version that works well with both old and
>>> new outputs.  I suggest instead
>>>
>>> "(?m)^ *[0-9]+: +([0-9]+) +[0-9]+ +\\Q"+className+"\\E(?:$| )";
>>>
>>> Does that work with latest serviceability changes?
>>>
>>> On Fri, Apr 29, 2016 at 11:00 AM, harold seigel
>>> <harold.seigel@oracle.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> Please review this extra small fix for test TimedAcquireLeak.java.  The
>>>> test
>>>> was broken by the recent change to add module information to the JMAP
>>>> class
>>>> histogram.  This fixes the test's regular expression to handle the
>>>> possible
>>>> additional module information.
>>>>
>>>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8155727/
>>>>
>>>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8155727
>>>>
>>>> Thanks! Harold
>>>>
>>
[prev in list] [next in list] [prev in thread] [next in thread]