[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: PerfData counter: sun.gc.policy.generations in JDK 8
From: Srinivas Ramakrishna <ysr1729 () gmail ! com>
Date: 2016-04-29 18:26:46
Message-ID: CABzyjy=nMww_R0BM+uZbXW2wsTLS6SZ8Kb9dQ91ighaK=PkeXQ () mail ! gmail ! com
[Download RAW message or body]
Sorry this fell off my plate. I'll dig up the test Jon pointed me to and
see how i can write one for this, then update the old webrev. I'll try and
get that done in the next few days.
thanks for the reminder! \
-- ramki
On Fri, Apr 15, 2016 at 6:43 AM, Stefan Karlsson <stefan.karlsson@oracle.com
> wrote:
> Hi Ramki and Jon,
>
> What's the status of this review thread? The bug is still open and
> targeted for JDK 9.
>
> Thanks,
> StefanK
>
>
> On 2015-06-03 08:15, Srinivas Ramakrishna wrote:
>
> Thanks Jon for the review and the pointer to the test. I'll get back to
> you later this week with a suitable test.
>
> -- Ramki
>
> ysr1729
>
> On Jun 2, 2015, at 14:16, Jon Masamitsu < <jon.masamitsu@oracle.com>
> jon.masamitsu@oracle.com> wrote:
>
> Ramki,
>
> Changes look good.
>
> I'm guessing you tested by generating the
> perfdata by hand and verifying the contents
> of the perfdata. Do you think a test can
> be written to verify the change? If you look at
>
> test/gc/metaspace/TestMetaspacePerfCounters.java
>
> in your repository I think that is an example that
> can be followed.
>
> It's a jtreg test.
>
> http://openjdk.java.net/jtreg/
>
> Jon
>
> On 06/01/2015 11:39 AM, Srinivas Ramakrishna wrote:
>
> Thanks for the review of the patch for 8-dev (from the ticket), Staffan.
>
> Sorry for the delay in getting the official webrev out -- it took me a
> while to first get set up with an hs9 repo (thanks Jon!) and then get my
> openjdk credentials updated (thanks Mark!).
>
> Here's the webrev against hs9 for official review:-
>
> http://cr.openjdk.java.net/~ysr/JDK-8080345/webrev.00/
>
> I built and tested the change (on both 8-dev whose patch was attached with
> the original bug, as well as this with hs9) and verified that the counter
> value for generations, in the perfdata file, was now 2 instead of the
> previous 3.
>
> thanks!
> -- ramki
>
>
> On Mon, May 18, 2015 at 1:22 AM, Staffan Larsen <
> <staffan.larsen@oracle.com>staffan.larsen@oracle.com> wrote:
>
>> Looks like a good patch to me.
>>
>> /Staffan
>>
>> On 14 maj 2015, at 18:12, Srinivas Ramakrishna < <ysr1729@gmail.com>
>> ysr1729@gmail.com> wrote:
>>
>> <https://bugs.openjdk.java.net/browse/JDK-8080345>
>> https://bugs.openjdk.java.net/browse/JDK-8080345
>>
>>
>>
>> On Wed, May 13, 2015 at 1:08 PM, Srinivas Ramakrishna <
>> <ysr1729@gmail.com>ysr1729@gmail.com> wrote:
>>
>>>
>>> With perm gen going away (and being replaced by metaspace) in JDK 8, it
>>> makes sense that the counter
>>> sun.gc.policy.generations should be "2", rather than "3". However, in
>>> JDK 8 that counter still says 3.
>>> As I understand, the intention was that this counter would allow you to
>>> (for example) know the range of
>>> the sun.gc.generation.$num.* counters describing each of $num <
>>> sun.gc.policy.generations in the heap.
>>> Recall that the erstwhile perm gen in JDK 7 used to be synonymous with
>>> sun.gc.generation.2, but the
>>> JDK 8 avatars are now sun.gc.metaspace and sun.gc.compressedclassspace.
>>>
>>> The fix is simple, and I can submit a patch. Is there an existing bug
>>> for this?
>>>
>>> thanks!
>>> -- ramki
>>>
>>
>>
>>
>
>
>
[Attachment #3 (text/html)]
<div dir="ltr"><br><div>Sorry this fell off my plate. I'll dig up the test Jon \
pointed me to and see how i can write one for this, then update the old webrev. \
I'll try and get that done in the next few days.</div><div><br></div><div>thanks \
for the reminder! \</div><div>-- ramki</div><div><br></div></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 15, 2016 at 6:43 AM, \
Stefan Karlsson <span dir="ltr"><<a href="mailto:stefan.karlsson@oracle.com" \
target="_blank">stefan.karlsson@oracle.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Hi Ramki and Jon,<br>
<br>
What's the status of this review thread? The bug is still open and
targeted for JDK 9.<br>
<br>
Thanks,<br>
StefanK<div><div class="h5"><br>
<br>
<div>On 2015-06-03 08:15, Srinivas
Ramakrishna wrote:<br>
</div>
<blockquote type="cite">
<div>Thanks Jon for the review and the pointer to the test. I'll
get back to you later this week with a suitable test.</div>
<div><br>
</div>
<div>-- Ramki<br>
<br>
ysr1729</div>
<div><br>
On Jun 2, 2015, at 14:16, Jon Masamitsu <<a \
href="mailto:jon.masamitsu@oracle.com" target="_blank"></a><a \
href="mailto:jon.masamitsu@oracle.com" \
target="_blank">jon.masamitsu@oracle.com</a>> wrote:<br>
<br>
</div>
<blockquote type="cite">
<div>
Ramki,<br>
<br>
Changes look good.<br>
<br>
I'm guessing you tested by generating the<br>
perfdata by hand and verifying the contents<br>
of the perfdata. Do you think a test can<br>
be written to verify the change? If you look at<br>
<br>
test/gc/metaspace/TestMetaspacePerfCounters.java<br>
<br>
in your repository I think that is an example that <br>
can be followed.<br>
<br>
It's a jtreg test.<br>
<br>
<a href="http://openjdk.java.net/jtreg/" \
target="_blank">http://openjdk.java.net/jtreg/</a><br> <br>
Jon<br>
<br>
<div>On 06/01/2015 11:39 AM, Srinivas
Ramakrishna wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Thanks for the review of the patch for 8-dev
(from the ticket), Staffan.
<div><br>
</div>
<div>Sorry for the delay in getting the official webrev
out -- it took me a while to first get set up with an
hs9 repo (thanks Jon!) and then get my openjdk
credentials updated (thanks Mark!).
<div><br>
</div>
<div>Here's the webrev against hs9 for official review:-</div>
<div><br>
</div>
<div><a \
href="http://cr.openjdk.java.net/%7Eysr/JDK-8080345/webrev.00/" \
target="_blank">http://cr.openjdk.java.net/~ysr/JDK-8080345/webrev.00/</a><br> \
</div> <div><br>
</div>
<div>I built and tested the change (on both 8-dev whose
patch was attached with the original bug, as well as
this with hs9) and verified that the counter value for
generations, in the perfdata file, was now 2 instead
of the previous 3.</div>
<div><br>
</div>
<div>thanks!</div>
<div>-- ramki</div>
<div><br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, May 18, 2015 at 1:22
AM, Staffan Larsen <span dir="ltr"><<a \
href="mailto:staffan.larsen@oracle.com" target="_blank"></a><a \
href="mailto:staffan.larsen@oracle.com" \
target="_blank">staffan.larsen@oracle.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> <div \
style="word-wrap:break-word">Looks like a good patch to me.<span><font \
color="#888888"> <div><br>
</div>
<div>/Staffan</div>
</font></span>
<div>
<div>
<div><br>
<div>
<blockquote type="cite">
<div>On 14 maj 2015, at 18:12,
Srinivas Ramakrishna <<a \
href="mailto:ysr1729@gmail.com" target="_blank"></a><a \
href="mailto:ysr1729@gmail.com" target="_blank">ysr1729@gmail.com</a>>
wrote:</div>
<br>
<div>
<div dir="ltr"><a \
href="https://bugs.openjdk.java.net/browse/JDK-8080345" style="font-size:13px" \
target="_blank"></a><a href="https://bugs.openjdk.java.net/browse/JDK-8080345" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8080345</a><br> <div><br>
</div>
<div><br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed,
May 13, 2015 at 1:08 PM,
Srinivas Ramakrishna <span dir="ltr"><<a \
href="mailto:ysr1729@gmail.com" target="_blank"></a><a \
href="mailto:ysr1729@gmail.com" target="_blank">ysr1729@gmail.com</a>></span> \
wrote:<br>
<blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div \
dir="ltr"><br> <div>With perm gen going
away (and being replaced
by metaspace) in JDK 8,
it makes sense that the
counter</div>
<div>sun.gc.policy.generations
should be "2", rather
than "3". However, in
JDK 8 that counter still
says 3.</div>
<div>As I understand, the
intention was that this
counter would allow you
to (for example) know
the range of</div>
<div>the
sun.gc.generation.$num.*
counters describing each
of $num <
sun.gc.policy.generations
in the heap.</div>
<div>Recall that the
erstwhile perm gen in
JDK 7 used to be
synonymous with
sun.gc.generation.2, but
the</div>
<div>JDK 8 avatars are now
sun.gc.metaspace and
sun.gc.compressedclassspace.</div>
<div><br>
</div>
<div>The fix is simple,
and I can submit a
patch. Is there an
existing bug for this?</div>
<div><br>
</div>
<div>thanks!</div>
<div>-- ramki</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
<br>
</div>
</blockquote>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic