[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR (XS): 8153190 JVMTI GetAllModules should make it clear that it also returns unnamed module
From: "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date: 2016-04-28 9:53:07
Message-ID: 5721DD83.8060800 () oracle ! com
[Download RAW message or body]
On 4/28/16 02:48, Alan Bateman wrote:
>
>
> On 28/04/2016 10:44, serguei.spitsyn@oracle.com wrote:
>> Please, review the JVM TI spec one-liner fix below.
>>
>>
>> The jvmti.xml patch:
>>
>> diff -r 888f37103953 src/share/vm/prims/jvmti.xml
>> --- a/src/share/vm/prims/jvmti.xml Wed Apr 27 11:25:16 2016 +0200
>> +++ b/src/share/vm/prims/jvmti.xml Thu Apr 28 02:24:09 2016 -0700
>> @@ -6482,6 +6482,7 @@
>> <synopsis>Get All Modules</synopsis>
>> <description>
>> Return an array of all modules loaded in the virtual machine.
>> + This includes the unnamed module for each class loader.
> Looks okay, alternative "The array include the unnamed module ...".
It makes sense, thanks.
The updated patch is:
diff -r 888f37103953 src/share/vm/prims/jvmti.xml
--- a/src/share/vm/prims/jvmti.xml Wed Apr 27 11:25:16 2016 +0200
+++ b/src/share/vm/prims/jvmti.xml Thu Apr 28 02:51:43 2016 -0700
@@ -6482,6 +6482,7 @@
<synopsis>Get All Modules</synopsis>
<description>
Return an array of all modules loaded in the virtual machine.
+ The array includes the unnamed module for each class loader.
The number of modules in the array is returned via
<code>module_count_ptr</code>, and the array itself via
<code>modules_ptr</code>.
Thanks,
Serguei
>
> -Alan.
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 4/28/16 02:48, Alan Bateman wrote:<br>
</div>
<blockquote cite="mid:5721DC60.7000303@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 28/04/2016 10:44, <a
moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:serguei.spitsyn@oracle.com"><a \
class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a></a> \
wrote:<br> </div>
<blockquote cite="mid:5721DB97.4070903@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<big><font size="-1"><big>Please, review the JVM TI spec
one-liner fix below.<br>
<br>
<br>
The jvmti.xml patch:<br>
<br>
diff -r 888f37103953 src/share/vm/prims/jvmti.xml<br>
--- a/src/share/vm/prims/jvmti.xml Wed Apr 27 11:25:16
2016 +0200<br>
+++ b/src/share/vm/prims/jvmti.xml Thu Apr 28 02:24:09
2016 -0700<br>
@@ -6482,6 +6482,7 @@<br>
<synopsis>Get All Modules</synopsis><br>
<description><br>
Return an array of all modules loaded in the virtual
machine.<br>
+ This includes the unnamed module for each class
loader.</big></font></big><br>
</blockquote>
Looks okay, alternative "The array include the unnamed module
...".<br>
</blockquote>
<br>
It makes sense, thanks.<br>
The updated patch is:<br>
<br>
diff -r 888f37103953 src/share/vm/prims/jvmti.xml<br>
--- a/src/share/vm/prims/jvmti.xml Wed Apr 27 11:25:16 2016 +0200<br>
+++ b/src/share/vm/prims/jvmti.xml Thu Apr 28 02:51:43 2016 -0700<br>
@@ -6482,6 +6482,7 @@<br>
<synopsis>Get All Modules</synopsis><br>
<description><br>
Return an array of all modules loaded in the virtual machine.<br>
+ The array includes the unnamed module for each class
loader.<br>
The number of modules in the array is returned via<br>
<code>module_count_ptr</code>, and the array itself
via<br>
<code>modules_ptr</code>.<br>
<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<blockquote cite="mid:5721DC60.7000303@oracle.com" type="cite"> <br>
-Alan.<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic