[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8155089: UL: Remove trailing comma from log decoration list
From:       Marcus Larsson <marcus.larsson () oracle ! com>
Date:       2016-04-27 6:11:10
Message-ID: b26afac4-417d-7ec8-3775-385e8555ba38 () oracle ! com
[Download RAW message or body]

Hi,


On 04/26/2016 03:08 PM, Yasumasa Suenaga wrote:
> Hi all,
>
> This review request relates [1].
>
> We can check log configuration through VM.log list jcmd:
> -------
> Log output configuration:
> #0: stdout vmoperation=debug,safepoint=info uptime,level,tags,
> #1: stderr all=warning uptime,level,tags,
> #2: gc.log gc=trace uptime,level,tags,
> -------
>
> Decorators are ended with comma.
> We should remove it as below:
> -------
> Log output configuration:
> #0: stdout vmoperation=debug,safepoint=info uptime,level,tags
> #1: stderr all=warning uptime,level,tags
> #2: gc.log gc=trace uptime,level,tags
> -------
>
> I uploaded a webrev for this issue.
> Could you review it?
>
>   http://cr.openjdk.java.net/~ysuenaga/JDK-8155089/webrev.00/

Looks good.

>
> I cannot access JPRT.
> So I need a sponsor.

I can sponsor.

Thanks,
Marcus

>
>
> Thanks,
>
> Yasumasa
>
>
> [1] 
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-April/019506.html

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic